Skip to content

Commit 41015e2

Browse files
author
Chen Bin
committed
Revert "support emacs 27"
This reverts commit 1d2c27d.
1 parent 1d2c27d commit 41015e2

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

.github/workflows/actions.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ jobs:
44
test-emacs-versions:
55
strategy:
66
matrix:
7-
emacs-version: [27, 28, 29]
7+
emacs-version: [28, 29]
88
runs-on: ubuntu-latest
99
container: silex/emacs:${{matrix.emacs-version}}-ci-eask
1010
steps:

Eask

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
(source "gnu")
1313
(source "melpa")
1414

15-
(depends-on "emacs" "27.1")
15+
(depends-on "emacs" "28.1")
1616

1717
(development
1818
(depends-on "el-mock")

js-comint.el

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
;;; Created: 15 Feb 2014
1010
;;; Version: 1.2.0
1111
;;; URL: https://github.com/redguardtoo/js-comint
12-
;;; Package-Requires: ((emacs "27.1"))
12+
;;; Package-Requires: ((emacs "28.1"))
1313
;;; Keywords: javascript, node, inferior-mode, convenience
1414

1515
;; This file is NOT part of GNU Emacs.

test/unit-tests.el

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,9 @@ reduce((prev, curr) => prev + curr, 0);"
8282

8383
(ert-deftest js-comint/test-strict-mode ()
8484
"When NODE_REPL_MODE=strict should use strict mode."
85-
(let ((old (getenv "NODE_REPL_MODE")))
86-
(unwind-protect
87-
(progn
88-
(setenv "NODE_REPL_MODE" "strict")
89-
;; global variables are not allowed in strict mode
90-
(js-comint-test-output-matches "foo = 5;" "Uncaught ReferenceError.*"))
91-
(setenv "NODE_REPL_MODE" old))))
85+
(with-environment-variables (("NODE_REPL_MODE" "strict"))
86+
;; global variables are not allowed in strict mode
87+
(js-comint-test-output-matches "foo = 5;" "Uncaught ReferenceError.*")))
9288

9389
(ert-deftest js-comint-select-node-version/test-no-nvm ()
9490
"Should error if nvm is missing."

0 commit comments

Comments
 (0)