Merge pull request #39 from joshbax189/feat/use-eask

Feat: use eask package manager

Author: redguardtoo

.github/workflows/actions.yml

@@ -6,11 +6,24 @@ jobs:
       matrix:
         emacs-version: [28, 29]
     runs-on: ubuntu-latest
-    container: silex/emacs:${{matrix.emacs-version}}
+    container: silex/emacs:${{matrix.emacs-version}}-ci-eask
     steps:
       - name: Check out repository code
         uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20
       - name: Install test dependencies
-        run: ./install-deps.sh
+        run: eask install-deps --dev
       - name: Run tests
-        run: ./runtests.sh
+        run: eask run script test
+  lint:
+    runs-on: ubuntu-latest
+    container: silex/emacs:29-ci-eask
+    steps:
+      - name: Check out repository code
+        uses: actions/checkout@v4
+      - name: Install test dependencies
+        run: eask install-deps --dev
+      - name: Run linters
+        run: eask lint declare --strict

.gitignore

@@ -0,0 +1,2 @@
+*.elc
+.eask

Eask

@@ -0,0 +1,19 @@
+(package "js-comint"
+         "1.2.0"
+         "JavaScript interpreter in window.")
+
+(website-url "https://github.com/redguardtoo/js-comint")
+(keywords "javascript" "node" "inferior-mode" "convenience")
+
+(package-file "js-comint.el")
+
+(script "test" "eask test ert test-js-comint.el")
+
+(source "gnu")
+(source "melpa")
+
+(depends-on "emacs" "28.1")
+
+(development
+ (depends-on "el-mock")
+ (depends-on "nvm"))

install-deps.sh

@@ -2,6 +2,7 @@
 
 (require 'js-comint)
 (require 'ert)
+(require 'el-mock)
 
 (defun js-comint-test-buffer-matches (regex)
   "Search the js-comint buffer for the given regular expression.
@@ -122,3 +123,49 @@ reduce((prev, curr) => prev + curr, 0);" "^9$")))
   (with-environment-variables (("NODE_REPL_MODE" "strict"))
     ;; global variables are not allowed in strict mode
     (js-comint-test-output-matches "foo = 5;" "Uncaught ReferenceError.*")))
+
+(ert-deftest js-comint-select-node-version/test-no-nvm ()
+  "Should error if nvm is missing."
+  (let ((original-command-value js-comint-program-command))
+    (with-mock
+     (mock (require 'nvm) => (error "Cannot open nvm"))
+     (should-error (js-comint-select-node-version))
+     (should-not js-use-nvm)
+     (should (equal js-comint-program-command
+                    original-command-value)))))
+
+(ert-deftest js-comint-select-node-version/test-with-arg ()
+  "Should set program-command when called non-interactively."
+  (let ((original-command-value js-comint-program-command)
+        (original-use-jvm-value js-use-nvm)
+        (original-nvm-version js-nvm-current-version))
+    (unwind-protect
+        (with-mock
+          (mock (require 'nvm))
+          (mock (nvm--find-exact-version-for "foo") => '("foo-1.2" "some_path"))
+          (js-comint-select-node-version "foo")
+          (should js-use-nvm)
+          (should (equal js-comint-program-command
+                         "some_path/bin/node"))
+          (should (equal js-nvm-current-version
+                         '("foo-1.2" "some_path"))))
+      (setq js-comint-program-command original-command-value
+            js-use-nvm original-use-jvm-value
+            js-nvm-current-version original-nvm-version))))
+
+(ert-deftest js-comint-select-node-version/test-optional-arg ()
+  "Should set program-command when called with no arg."
+  (let ((original-command-value js-comint-program-command)
+        (original-use-jvm-value js-use-nvm)
+        (original-nvm-version js-nvm-current-version))
+    (unwind-protect
+        (with-mock
+          (mock (require 'nvm))
+          (mock (js-comint-list-nvm-versions *) => "foo")
+          (mock (nvm--find-exact-version-for "foo") => '("foo-1.2" "some_path"))
+          (js-comint-select-node-version)
+          (should (equal js-comint-program-command
+                         "some_path/bin/node")))
+      (setq js-comint-program-command original-command-value
+            js-use-nvm original-use-jvm-value
+            js-nvm-current-version original-nvm-version))))