Skip to content

Commit 7ed19de

Browse files
committed
fix: fixing codecoverage response for non verbose
1 parent ea7024e commit 7ed19de

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

schemas/package-version-list.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@
120120
"Branch",
121121
"BuildDurationInSeconds",
122122
"BuildNumber",
123+
"CodeCoverage",
123124
"CreatedBy",
124125
"CreatedDate",
125126
"Description",

src/commands/package/version/list.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export type PackageVersionListDetails = Omit<
3636
IsReleased: string | boolean;
3737
HasPassedCodeCoverageCheck: string | boolean;
3838
BuildDurationInSeconds: string | number;
39-
CodeCoverage: string | undefined;
39+
CodeCoverage: string;
4040
NamespacePrefix: string;
4141
Package2Name: string;
4242
Version: string;
@@ -148,12 +148,17 @@ export class PackageVersionListCommand extends SfCommand<PackageVersionListComma
148148
record.AncestorId = 'N/A';
149149
}
150150

151-
const codeCoverage =
152-
record.CodeCoverage?.apexCodeCoveragePercentage != null
151+
function getCodeCoverage(): string {
152+
if (flags.verbose) {
153+
return 'use --verbose for code coverage';
154+
}
155+
156+
return record.CodeCoverage?.apexCodeCoveragePercentage != null
153157
? `${record.CodeCoverage.apexCodeCoveragePercentage.toString()}%`
154158
: Boolean(record.Package2.IsOrgDependent) || record.ValidationSkipped
155159
? 'N/A'
156160
: '';
161+
}
157162

158163
const hasPassedCodeCoverageCheck =
159164
record.Package2.IsOrgDependent === true || record.ValidationSkipped
@@ -192,7 +197,7 @@ export class PackageVersionListCommand extends SfCommand<PackageVersionListComma
192197
CreatedDate: new Date(record.CreatedDate).toISOString().replace('T', ' ').substring(0, 16),
193198
LastModifiedDate: new Date(record.LastModifiedDate).toISOString().replace('T', ' ').substring(0, 16),
194199
InstallUrl: INSTALL_URL_BASE.toString() + record.SubscriberPackageVersionId,
195-
CodeCoverage: flags.verbose ? codeCoverage : undefined,
200+
CodeCoverage: getCodeCoverage(),
196201
HasPassedCodeCoverageCheck: hasPassedCodeCoverageCheck as string | boolean,
197202
ValidationSkipped: record.ValidationSkipped,
198203
ValidatedAsync: record.ValidatedAsync,

test/commands/package/packageVersion.nut.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,7 @@ describe('package:version:*', () => {
330330
'CreatedDate',
331331
'LastModifiedDate',
332332
'InstallUrl',
333+
'CodeCoverage',
333334
'ValidationSkipped',
334335
'ValidatedAsync',
335336
'AncestorId',
@@ -388,7 +389,7 @@ describe('package:version:*', () => {
388389
expect(output).to.have.length.greaterThan(0);
389390
expect(output[0]).to.have.keys(keys);
390391
(output as PackageVersionListDetails[])
391-
.filter((f: { CodeCoverage: string | undefined }) => f.CodeCoverage)
392+
.filter((f: { CodeCoverage: string | boolean }) => f.CodeCoverage)
392393
.map((v: { SubscriberPackageVersionId: string }) => packageVersionIds.push(v.SubscriberPackageVersionId));
393394
});
394395

0 commit comments

Comments
 (0)