fix: resolve CI failures for snow run command

Fix code quality issues (trailing whitespace, ruff G004 f-string logging,
black formatting), Windows test failures (subprocess mock was polluting
global scope via shared module reference), and update E2E snapshots to
include the new run command in snow --help output.

.... Generated with [Cortex Code](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code)

Co-Authored-By: Cortex Code <[email protected]>

Author: sfc-gh-mborins

src/snowflake/cli/_plugins/run/commands.py

@@ -116,7 +116,9 @@ def run_script(
             for name in scripts:
                 cc.message(f"  {name}")
             return MessageResult("\nSpecify a script name to run, or use --list")
-        return MessageResult("No scripts defined. Add a 'scripts' section to snowflake.yml or manifest.yml")
+        return MessageResult(
+            "No scripts defined. Add a 'scripts' section to snowflake.yml or manifest.yml"
+        )
 
     vars_dict = {}
     if var_overrides:

src/snowflake/cli/_plugins/run/manager.py

@@ -18,10 +18,10 @@
 import os
 import re
 import shlex
-import subprocess
 import sys
 from dataclasses import dataclass
 from pathlib import Path
+from subprocess import run as _subprocess_run
 from typing import Dict, List, Optional, Tuple
 
 import yaml
@@ -58,7 +58,7 @@ def __init__(self, project_root: Path):
 
     def _load_scripts(self) -> None:
         """Load scripts from snowflake.yml or manifest.yml.
-        
+
         Scripts can be defined in either file but not both.
         Raises ClickException if scripts are found in both files.
         """
@@ -81,15 +81,23 @@ def _load_scripts(self) -> None:
             self._scripts = manifest_scripts
             self._scripts_source = manifest_source
 
-    def _load_snowflake_scripts(self) -> Tuple[Optional[Dict[str, ScriptModel]], Optional[str]]:
+    def _load_snowflake_scripts(
+        self,
+    ) -> Tuple[Optional[Dict[str, ScriptModel]], Optional[str]]:
         """Load scripts from snowflake.yml via project definition."""
         ctx = get_cli_context()
         project_def = ctx.project_definition
-        if project_def and isinstance(project_def, DefinitionV20) and project_def.scripts:
+        if (
+            project_def
+            and isinstance(project_def, DefinitionV20)
+            and project_def.scripts
+        ):
             return project_def.scripts, "snowflake.yml"
         return None, None
 
-    def _load_manifest_scripts(self) -> Tuple[Optional[Dict[str, ScriptModel]], Optional[str]]:
+    def _load_manifest_scripts(
+        self,
+    ) -> Tuple[Optional[Dict[str, ScriptModel]], Optional[str]]:
         """Load scripts from manifest.yml if present."""
         manifest_path = SecurePath(self.project_root / MANIFEST_FILE_NAME)
         if not manifest_path.exists():
@@ -99,7 +107,7 @@ def _load_manifest_scripts(self) -> Tuple[Optional[Dict[str, ScriptModel]], Opti
             with manifest_path.open("r", read_file_limit_mb=DEFAULT_SIZE_LIMIT_MB) as f:
                 manifest_data = yaml.safe_load(f.read())
         except Exception as e:
-            log.debug(f"Could not read manifest.yml: {e}")
+            log.debug("Could not read manifest.yml: %s", e)
             return None, None
 
         if not manifest_data or "scripts" not in manifest_data:
@@ -216,7 +224,13 @@ def execute_script(
 
         if script.run:
             return self._execute_composite(
-                name, script, extra_args, var_overrides, dry_run, verbose, continue_on_error
+                name,
+                script,
+                extra_args,
+                var_overrides,
+                dry_run,
+                verbose,
+                continue_on_error,
             )
 
         return self._execute_command(
@@ -260,14 +274,14 @@ def _execute_command(
                 )
 
             if sys.platform == "win32":
-                result = subprocess.run(
+                result = _subprocess_run(
                     cmd,
                     shell=True,
                     cwd=cwd,
                     env=env,
                 )
             else:
-                result = subprocess.run(
+                result = _subprocess_run(
                     cmd,
                     shell=True,
                     cwd=cwd,
@@ -276,7 +290,7 @@ def _execute_command(
                 )
         else:
             args = shlex.split(cmd)
-            result = subprocess.run(
+            result = _subprocess_run(
                 args,
                 cwd=cwd,
                 env=env,

tests/run/test_commands.py

@@ -14,9 +14,7 @@
 
 from unittest import mock
 
-import pytest
-
-SUBPROCESS_RUN = "snowflake.cli._plugins.run.manager.subprocess.run"
+SUBPROCESS_RUN = "snowflake.cli._plugins.run.manager._subprocess_run"
 
 
 class TestRunList:
@@ -96,15 +94,19 @@ def test_run_composite_script(self, mock_run, runner, project_directory):
             assert "2 scripts executed" in result.output
 
     @mock.patch(SUBPROCESS_RUN)
-    def test_run_composite_script_stops_on_error(self, mock_run, runner, project_directory):
+    def test_run_composite_script_stops_on_error(
+        self, mock_run, runner, project_directory
+    ):
         mock_run.return_value = mock.Mock(returncode=1)
         with project_directory("run_scripts"):
             result = runner.invoke(["run", "deploy-all"])
             assert result.exit_code == 1
             assert mock_run.call_count == 1
 
     @mock.patch(SUBPROCESS_RUN)
-    def test_run_composite_script_continue_on_error(self, mock_run, runner, project_directory):
+    def test_run_composite_script_continue_on_error(
+        self, mock_run, runner, project_directory
+    ):
         mock_run.return_value = mock.Mock(returncode=1)
         with project_directory("run_scripts"):
             result = runner.invoke(["run", "deploy-all", "--continue-on-error"])
@@ -168,7 +170,9 @@ def test_run_script_from_manifest(self, mock_run, runner, project_directory):
             assert "echo" in mock_run.call_args[0][0][0]
 
     @mock.patch(SUBPROCESS_RUN)
-    def test_run_composite_script_from_manifest(self, mock_run, runner, project_directory):
+    def test_run_composite_script_from_manifest(
+        self, mock_run, runner, project_directory
+    ):
         mock_run.return_value = mock.Mock(returncode=0)
         with project_directory("run_manifest_scripts"):
             result = runner.invoke(["run", "all"])

tests/run/test_integration.py

@@ -12,22 +12,16 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import os
-from pathlib import Path
 from unittest import mock
 
-import pytest
-
-SUBPROCESS_RUN = "snowflake.cli._plugins.run.manager.subprocess.run"
+SUBPROCESS_RUN = "snowflake.cli._plugins.run.manager._subprocess_run"
 
 
 class TestRunIntegration:
     """Integration tests for snow run command."""
 
     @mock.patch(SUBPROCESS_RUN)
-    def test_run_echo_script_in_real_project(
-        self, mock_run, runner, project_directory
-    ):
+    def test_run_echo_script_in_real_project(self, mock_run, runner, project_directory):
         """Test running a simple echo script."""
         mock_run.return_value = mock.Mock(returncode=0)
         with project_directory("run_scripts"):
@@ -38,9 +32,7 @@ def test_run_echo_script_in_real_project(
             mock_run.assert_called_once()
 
     @mock.patch(SUBPROCESS_RUN)
-    def test_composite_script_runs_all_steps(
-        self, mock_run, runner, project_directory
-    ):
+    def test_composite_script_runs_all_steps(self, mock_run, runner, project_directory):
         """Test composite script executes all child scripts."""
         mock_run.return_value = mock.Mock(returncode=0)
         with project_directory("run_scripts"):
@@ -63,9 +55,7 @@ def test_variable_interpolation_from_env_section(
             assert "TEMP.DEV_PLATFORM" in cmd
 
     @mock.patch(SUBPROCESS_RUN)
-    def test_override_variable_from_cli(
-        self, mock_run, runner, project_directory
-    ):
+    def test_override_variable_from_cli(self, mock_run, runner, project_directory):
         """Test that -D flag properly overrides variables."""
         mock_run.return_value = mock.Mock(returncode=0)
         with project_directory("run_scripts"):
@@ -75,9 +65,7 @@ def test_override_variable_from_cli(
             assert "PRODUCTION" in cmd
 
     @mock.patch(SUBPROCESS_RUN)
-    def test_shell_mode_for_pipes(
-        self, mock_run, runner, project_directory
-    ):
+    def test_shell_mode_for_pipes(self, mock_run, runner, project_directory):
         """Test that shell=true scripts use shell execution."""
         mock_run.return_value = mock.Mock(returncode=0)
         with project_directory("run_scripts"):

tests_e2e/__snapshots__/test_installation.ambr

@@ -40,6 +40,8 @@
   | logs                 Retrieves logs for a given object.                      |
   | notebook             Manages notebooks in Snowflake.                         |
   | object               Manages Snowflake objects like warehouses and stages    |
+  | run                  Execute project scripts defined in snowflake.yml or     |
+  |                      manifest.yml.                                           |
   | snowpark             Manages procedures and functions.                       |
   | spcs                 Manages Snowpark Container Services compute pools,      |
   |                      services, image registries, and image repositories.     |
@@ -104,6 +106,8 @@
   | logs         Retrieves logs for a given object.                              |
   | notebook     Manages notebooks in Snowflake.                                 |
   | object       Manages Snowflake objects like warehouses and stages            |
+  | run          Execute project scripts defined in snowflake.yml or             |
+  |              manifest.yml.                                                   |
   | snowpark     Manages procedures and functions.                               |
   | spcs         Manages Snowpark Container Services compute pools, services,    |
   |              image registries, and image repositories.                       |
@@ -149,6 +153,8 @@
   | logs                 Retrieves logs for a given object.                      |
   | notebook             Manages notebooks in Snowflake.                         |
   | object               Manages Snowflake objects like warehouses and stages    |
+  | run                  Execute project scripts defined in snowflake.yml or     |
+  |                      manifest.yml.                                           |
   | snowpark             Manages procedures and functions.                       |
   | spcs                 Manages Snowpark Container Services compute pools,      |
   |                      services, image registries, and image repositories.     |
@@ -233,6 +239,8 @@
   | logs         Retrieves logs for a given object.                              |
   | notebook     Manages notebooks in Snowflake.                                 |
   | object       Manages Snowflake objects like warehouses and stages            |
+  | run          Execute project scripts defined in snowflake.yml or             |
+  |              manifest.yml.                                                   |
   | snowpark     Manages procedures and functions.                               |
   | spcs         Manages Snowpark Container Services compute pools, services,    |
   |              image registries, and image repositories.                       |