Skip to content

Commit 16960dd

Browse files
fix: Title-casing of target types for consistency (#31)
1 parent b3585d4 commit 16960dd

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

extappdynamics/discovery_healthrules.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ func (d *healthRuleDiscovery) Describe() discovery_kit_api.DiscoveryDescription
5959
func (d *healthRuleDiscovery) DescribeTarget() discovery_kit_api.TargetDescription {
6060
return discovery_kit_api.TargetDescription{
6161
Id: applicationHealthRuleTargetType,
62-
Label: discovery_kit_api.PluralLabel{One: "AppDynamics health-rule", Other: "AppDynamics health-rules"},
62+
Label: discovery_kit_api.PluralLabel{One: "AppDynamics Health Rule", Other: "AppDynamics Health Rules"},
6363
Category: extutil.Ptr("monitoring"),
6464
Version: extbuild.GetSemverVersionStringOrUnknown(),
6565
Icon: extutil.Ptr(appDynamicsTargetIcon),

extappdynamics/discovery_healthrules_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ package extappdynamics
33

44
import (
55
"context"
6-
"github.com/steadybit/discovery-kit/go/discovery_kit_api"
76
"net/http"
87
"net/http/httptest"
98
"testing"
109

10+
"github.com/steadybit/discovery-kit/go/discovery_kit_api"
11+
1112
"github.com/go-resty/resty/v2"
1213
"github.com/stretchr/testify/assert"
1314
)
@@ -84,8 +85,8 @@ func TestHealthRuleDiscovery_DescribeTarget(t *testing.T) {
8485
td := d.DescribeTarget()
8586

8687
assert.Equal(t, applicationHealthRuleTargetType, td.Id)
87-
assert.Equal(t, "AppDynamics health-rule", td.Label.One)
88-
assert.Equal(t, "AppDynamics health-rules", td.Label.Other)
88+
assert.Equal(t, "AppDynamics Health Rule", td.Label.One)
89+
assert.Equal(t, "AppDynamics Health Rules", td.Label.Other)
8990
assert.NotNil(t, td.Category)
9091
assert.Equal(t, "monitoring", *td.Category)
9192
// should list exactly 5 columns

0 commit comments

Comments
 (0)