Skip to content

Commit 069c3ed

Browse files
author
Larsen, Steffen
committed
Address comments
Signed-off-by: Larsen, Steffen <[email protected]>
1 parent 6a5cee7 commit 069c3ed

File tree

2 files changed

+18
-19
lines changed

2 files changed

+18
-19
lines changed

adoc/chapters/architecture.adoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1424,13 +1424,13 @@ must include the <<backend>>-specific headers for said <<backend>>.
14241424
A <<command-group-function-object>> can be submitted either to a single queue to
14251425
be executed on, or to a secondary queue.
14261426
If a <<command-group-function-object>> fails to be enqueued to the primary
1427-
queue, then the system may attempt to enqueue it to the secondary queue, if
1428-
given as a parameter to the submit function. It is implementation defined
1427+
queue, then the implementation may attempt to enqueue it to the secondary queue,
1428+
if given as a parameter to the submit function. It is implementation defined
14291429
whether the secondary queue is used as a fallback in this manner.
1430-
If the <<command-group-function-object>> fails to be queued to both of these
1431-
queues, or if it fails to be queued to the primary queue and the implementation
1432-
elects not to enqueue it to the secondary queue, then a synchronous SYCL
1433-
exception will be thrown.
1430+
If the <<command-group-function-object>> fails to be enqueued to both of these
1431+
queues, or if it fails to be enqueued to the primary queue and the
1432+
implementation elects not to enqueue it to the secondary queue, then a
1433+
synchronous SYCL exception will be thrown.
14341434

14351435
It is possible that a command group may be successfully enqueued, but then
14361436
asynchronously fail to run, for some reason.

adoc/chapters/programming_interface.adoc

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5442,7 +5442,7 @@ placeholder) or from [code]#handler::require()# (if the accessor is a
54425442
placeholder). If the accessor is bound to a <<command-group>> with a secondary
54435443
queue, the sub-buffer's alignment must be compatible with both the primary
54445444
queue's device and the secondary queue's device. If the implementation supports
5445-
the secondary queue fallback, it also throws this exception if the sub-buffer's
5445+
secondary queue fallback, it also throws this exception if the sub-buffer's
54465446
alignment is not compatible with the secondary queue's device.
54475447

54485448
_Throws:_
@@ -14227,7 +14227,7 @@ the primary queue.
1422714227
If the <<sycl-runtime>> fails to enqueue or execute a command group on a primary
1422814228
queue, it can attempt to run the command group on the secondary queue.
1422914229
The circumstances in which the <<sycl-runtime>> may elect to
14230-
fall-back from primary to secondary queue are unspecified in the specification.
14230+
fall-back from primary to secondary queue are unspecified.
1423114231
Even if a command group is run on the secondary queue, the requirement that host
1423214232
code within the command group is executed exactly once remains, regardless of
1423314233
whether the fallback queue is used for execution.
@@ -14523,8 +14523,8 @@ code if the [code]#kernelObject# is not compatible with the device
1452314523
associated with the primary queue of the <<command-group>>.
1452414524
Throws an [code]#exception# with the [code]#errc::kernel_not_supported# error
1452514525
code if the <<command-group>> has a secondary queue, the implementation supports
14526-
the secondary queue fallback, and the [code]#kernelObject# is not compatible
14527-
with the device associated with the secondary queue.
14526+
secondary queue fallback, and the [code]#kernelObject# is not compatible with
14527+
the device associated with the secondary queue.
1452814528

1452914529
a@
1453014530
[source]
@@ -14548,8 +14548,8 @@ code if the [code]#kernelObject# is not compatible with the device associated
1454814548
with the primary queue of the <<command-group>>.
1454914549
Throws an [code]#exception# with the [code]#errc::kernel_not_supported# error
1455014550
code if the <<command-group>> has a secondary queue, the implementation supports
14551-
the secondary queue fallback, and the [code]#kernelObject# is not compatible
14552-
with the device associated with the secondary queue.
14551+
secondary queue fallback, and the [code]#kernelObject# is not compatible with
14552+
the device associated with the secondary queue.
1455314553

1455414554
a@
1455514555
[source]
@@ -14578,8 +14578,8 @@ code if the [code]#kernelObject# is not compatible with the device associated
1457814578
with the primary queue of the <<command-group>>.
1457914579
Throws an [code]#exception# with the [code]#errc::kernel_not_supported# error
1458014580
code if the <<command-group>> has a secondary queue, the implementation supports
14581-
the secondary queue fallback, and the [code]#kernelObject# is not compatible
14582-
with the device associated with the secondary queue.
14581+
secondary queue fallback, and the [code]#kernelObject# is not compatible with
14582+
the device associated with the secondary queue.
1458314583

1458414584
|====
1458514585

@@ -15211,10 +15211,9 @@ compatible device image in [code]#execBundle#, the <<kernel-invocation-command>>
1521115211
throws a synchronous [code]#exception# with the
1521215212
[code]#errc::kernel_not_supported# error code.
1521315213
If the <<command-group>> has a secondary queue and the implementation supports
15214-
the secondary queue fallback, then the [code]#execBundle# must contain a kernel
15215-
that is compatible with both the primary queue's device and the secondary
15216-
queue's device, otherwise the <<kernel-invocation-command>> throws this
15217-
exception.
15214+
secondary queue fallback, then the [code]#execBundle# must contain a kernel that
15215+
is compatible with both the primary queue's device and the secondary queue's
15216+
device, otherwise the <<kernel-invocation-command>> throws this exception.
1521815217

1521915218
Since the handler method for setting specialization constants is incompatible
1522015219
with the kernel bundle method, applications should not call this function if
@@ -15230,7 +15229,7 @@ _Throws:_
1523015229

1523115230
* An [code]#exception# with the [code]#errc::invalid# error code if the
1523215231
<<handler>> has an associated secondary <<queue>>, the implementation
15233-
supports the secondary queue fallback, and the <<context>> of the secondary
15232+
supports secondary queue fallback, and the <<context>> of the secondary
1523415233
queue is different from the <<context>> associated with the
1523515234
<<kernel-bundle>> specified by [code]#execBundle#.
1523615235

0 commit comments

Comments
 (0)