Skip to content

Test Cleanup #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stevan opened this issue Oct 4, 2018 · 0 comments
Open

Test Cleanup #22

stevan opened this issue Oct 4, 2018 · 0 comments
Labels
needs improvement Something that needs some improvement

Comments

@stevan
Copy link
Owner

stevan commented Oct 4, 2018 •
edited
Loading

There is a lot of copy paste in the tests, which is not a problem so much, but some of the things that were copy/pasted are now not the best way to do things.

One example is any use of Graph::QL::Schema::Type::* classes should be replaced by the Graph::QL::Util::Schemas::construct_type_from_name instead.

Additionally the messages in the tests are not always accurate, and often will reflect the origin of the copy/paste more than the test it is actually supposed to be describing.

Otherwise just a general cleaning to make sure tests are still useful is always good.
@stevan stevan added the needs improvement Something that needs some improvement label Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs improvement Something that needs some improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevan