You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We still need to do away with the enable_for_schema and enable_for_resolvers class methods, both of them will make clones of the Schema and Resolver objects respectively and I am not a fan of that (though it is a shallow clone and since everything is immutable thats safe).
Most all other fields are now "implicit" and are handled in a way similar to the BuiltIn::Scalars in that they will return constant values (technically state variables, so the are not actually created if they are never called, but afterwards return the same values without recalculating).
However, a few things still need attention, like the implicit Query fields are currently added to all Object types, not just the Query instance, and we have no support for __typename.
So basically this ticket needs the following tasks completed to be closed.
Handle __typename
Remove the need for enable_for_schema by making what it does "implicit"
Remove the need for enable_for_resolvers by making what it does "implicit"
Restrict the __schema and __type(name) fields to the Query class (simply Proxy class should suffice)
The text was updated successfully, but these errors were encountered:
Uh oh!
There was an error while loading. Please reload this page.
This work was started in eaef95e
We still need to do away with the
enable_for_schema
andenable_for_resolvers
class methods, both of them will make clones of theSchema
andResolver
objects respectively and I am not a fan of that (though it is a shallow clone and since everything is immutable thats safe).Most all other fields are now "implicit" and are handled in a way similar to the
BuiltIn::Scalars
in that they will return constant values (technicallystate
variables, so the are not actually created if they are never called, but afterwards return the same values without recalculating).Query
introspection fields (__schema
,__type(name)
)Query
fieldsHowever, a few things still need attention, like the implicit
Query
fields are currently added to allObject
types, not just theQuery
instance, and we have no support for__typename
.So basically this ticket needs the following tasks completed to be closed.
__typename
enable_for_schema
by making what it does "implicit"enable_for_resolvers
by making what it does "implicit"__schema
and__type(name)
fields to theQuery
class (simply Proxy class should suffice)The text was updated successfully, but these errors were encountered: