Skip to content

Introspection Needs an overhaul #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 tasks
stevan opened this issue Oct 4, 2018 · 0 comments
Open
4 tasks

Introspection Needs an overhaul #24

stevan opened this issue Oct 4, 2018 · 0 comments
Labels
needs improvement Something that needs some improvement
Milestone

Comments

@stevan
Copy link
Owner

stevan commented Oct 4, 2018

This work was started in eaef95e

We still need to do away with the enable_for_schema and enable_for_resolvers class methods, both of them will make clones of the Schema and Resolver objects respectively and I am not a fan of that (though it is a shallow clone and since everything is immutable thats safe).

Most all other fields are now "implicit" and are handled in a way similar to the BuiltIn::Scalars in that they will return constant values (technically state variables, so the are not actually created if they are never called, but afterwards return the same values without recalculating).

However, a few things still need attention, like the implicit Query fields are currently added to all Object types, not just the Query instance, and we have no support for __typename.

So basically this ticket needs the following tasks completed to be closed.

  • Handle __typename
  • Remove the need for enable_for_schema by making what it does "implicit"
  • Remove the need for enable_for_resolvers by making what it does "implicit"
  • Restrict the __schema and __type(name) fields to the Query class (simply Proxy class should suffice)
@stevan stevan added the needs improvement Something that needs some improvement label Oct 4, 2018
@stevan stevan added this to the v0.1.0 milestone Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs improvement Something that needs some improvement
Projects
None yet
Development

No branches or pull requests

1 participant