Merge pull request #1424 from vojtechtrefny/main_vg-size-zero-fix

Make sure size for VGs without PVs is Size not int

Author: vojtechtrefny

blivet/devices/lvm.py

@@ -582,6 +582,8 @@ def lvm_metadata_space(self):
     def size(self):
         """ The size of this VG """
         # TODO: just ask lvm if isModified returns False
+        if not self.pvs:
+            return Size(0)
         return sum(self._get_pv_usable_space(pv) for pv in self.pvs)
 
     @property

tests/unit_tests/devices_test/lvm_test.py

@@ -508,6 +508,11 @@ def test_vg_is_empty(self):
                                exists=False)
         self.assertFalse(vg.is_empty)
 
+    def test_vg_size_zero(self):
+        vg = LVMVolumeGroupDevice("testvg", parents=[])
+        self.assertEqual(vg.size, Size(0))
+        self.assertEqual(vg.extents, 0)
+
     def test_lvm_vdo_pool(self):
         pv = StorageDevice("pv1", fmt=blivet.formats.get_format("lvmpv"),
                            size=Size("1 GiB"), exists=True)