feat: Enable to set additional mount points #412
Conversation
snovikov
changed the title
| @@ -186,11 +186,11 @@ module "acm" { | |||
|
|
|||
| locals { | |||
| mount_path = "/home/atlantis" | |||
| mount_points = var.enable_efs ? [{ | |||
| mount_points = var.enable_efs ? concat(try(var.atlantis.mount_points, []), [{ | |||
There was a problem hiding this comment.
I think this is such an edge case that if you want to do it, you might as well just provide all of the mount points (and therefore, no change required here)
There was a problem hiding this comment.
In case if enable_efs is true - EFS volume and acces points are manged in the atlantis module, but var.atlantis.mount_points is ignored - it is not possible to provide all mount points as you suggested.
The only option would be to set enable_efs to false and manage EFS elsewhere.
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR was automatically closed because of stale in 10 days |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This will allow to add mount points in the container alongside EFS.
Motivation and Context
When
enable_efsis set totrueit is not possible to set additional mount points for the container.In case when you need to set
readonlyRootFilesystemthis could be necessary for accesing the container via session manager.Links:
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request