fix: Updated Log Group possible retention days #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anbotero
changed the title
anbotero
changed the title
antonbabenko
changed the title
antonbabenko
approved these changes
Mar 6, 2025
antonbabenko
merged commit ec7e34a
into
terraform-aws-modules:master
34 of 36 checks passed
|
This PR is included in version 5.7.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some Retention settings were missing and they are now offered by AWS CloudWatch Logs.
Motivation and Context
While working on a HIPAA related project, I tried to setup the retention days to
2192(6 years), and that’s when I got the validation error:The numbers now match against AWS Console and most importantly also with
aws_cloudwatch_log_groupparameters on AWS Provider.Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsI tested using the Module with both
0and2192values.pre-commit run -aon my pull request