sqs_managed_sse_enabled = false in Karpenter creates SQS with SSE enabled

[albert-liftoff]

Description

In the Karpenter module, setting sqs_managed_sse_enabled = false still creates SQS with SSE enabled.

This might be due to the following line which sets the underlying aws_sqs_queue resource with sqs_managed_sse_enabled = null.

https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/modules/karpenter/main.tf#L147

• ✋ I have searched the open/closed issues and my issue is not listed.

⚠️ Note

Before you submit an issue, please perform the following first:

1. Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
2. Re-initialize the project root to pull down modules: terraform init
3. Re-attempt your terraform plan or apply and check if the issue still persists

Versions

• Module version [Required]:

• Terraform version:

• Provider version(s):

Reproduction Code [Required]

module "karpenter" {
  source = "terraform-aws-modules/eks/aws//modules/karpenter"

  namespace = "karpenter"

  # ...
  queue_managed_sse_enabled = false

}

Steps to reproduce the behavior:

Expected behavior

Actual behavior

Terminal Output Screenshot(s)

Additional context

[nantiferov]

Yep, AWS changed API defaults in 2022 and now if it's not set, it means enabled rather than disabled before hashicorp/terraform-provider-aws#22197

I think this line should be just set to variable instead of ternary. Shouldn't break anything I think, but need to test.

resource "aws_sqs_queue" "this" {
...
  sqs_managed_sse_enabled           = var.queue_managed_sse_enabled
}

[bryantbiggs]

looks like we should change the default variable and logic on the next breaking change