Skip to content

Commit ab9e4f5

Browse files
Update description of the new variable to drop the mention of CMK
Rename variable to reflect the fact that the ARN is needed, not the ID
1 parent a551b01 commit ab9e4f5

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

modules/iam-role-for-service-accounts-eks/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ No modules.
233233
| <a name="input_load_balancer_controller_targetgroup_arns"></a> [load\_balancer\_controller\_targetgroup\_arns](#input\_load\_balancer\_controller\_targetgroup\_arns) | List of Target groups ARNs using Load Balancer Controller | `list(string)` | <pre>[<br> "arn:aws:elasticloadbalancing:*:*:targetgroup/*/*"<br>]</pre> | no |
234234
| <a name="input_max_session_duration"></a> [max\_session\_duration](#input\_max\_session\_duration) | Maximum CLI/API session duration in seconds between 3600 and 43200 | `number` | `null` | no |
235235
| <a name="input_mountpoint_s3_csi_bucket_arns"></a> [mountpoint\_s3\_csi\_bucket\_arns](#input\_mountpoint\_s3\_csi\_bucket\_arns) | S3 bucket ARNs to allow Mountpoint S3 CSI to list buckets | `list(string)` | `[]` | no |
236-
| <a name="input_mountpoint_s3_csi_kms_ids"></a> [mountpoint\_s3\_csi\_kms\_ids](#input\_mountpoint\_s3\_csi\_kms\_ids) | KMS CMK IDs to allow Mountpoint S3 CSI driver to download and upload Objects of a S3 bucket using `aws:kms` SSE | `list(string)` | `[]` | no |
236+
| <a name="input_mountpoint_s3_csi_kms_arns"></a> [mountpoint\_s3\_csi\_kms\_arns](#input\_mountpoint\_s3\_csi\_kms\_arns) | KMS Key ARNs to allow Mountpoint S3 CSI driver to download and upload Objects of a S3 bucket using `aws:kms` SSE | `list(string)` | `[]` | no |
237237
| <a name="input_mountpoint_s3_csi_path_arns"></a> [mountpoint\_s3\_csi\_path\_arns](#input\_mountpoint\_s3\_csi\_path\_arns) | S3 path ARNs to allow Mountpoint S3 CSI driver to manage items at the provided path(s). This is required if `attach_mountpoint_s3_csi_policy = true` | `list(string)` | `[]` | no |
238238
| <a name="input_node_termination_handler_sqs_queue_arns"></a> [node\_termination\_handler\_sqs\_queue\_arns](#input\_node\_termination\_handler\_sqs\_queue\_arns) | List of SQS ARNs that contain node termination events | `list(string)` | <pre>[<br> "*"<br>]</pre> | no |
239239
| <a name="input_oidc_providers"></a> [oidc\_providers](#input\_oidc\_providers) | Map of OIDC providers where each provider map should contain the `provider_arn` and `namespace_service_accounts` | `any` | `{}` | no |

modules/iam-role-for-service-accounts-eks/policies.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,14 +449,14 @@ data "aws_iam_policy_document" "mountpoint_s3_csi" {
449449
}
450450

451451
dynamic "statement" {
452-
for_each = length(var.mountpoint_s3_csi_kms_ids) > 0 ? [1] : []
452+
for_each = length(var.mountpoint_s3_csi_kms_arns) > 0 ? [1] : []
453453
content {
454454
actions = [
455455
"kms:GenerateDataKey",
456456
"kms:Decrypt"
457457
]
458458

459-
resources = var.mountpoint_s3_csi_kms_ids
459+
resources = var.mountpoint_s3_csi_kms_arns
460460
}
461461
}
462462
}

modules/iam-role-for-service-accounts-eks/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ variable "mountpoint_s3_csi_bucket_arns" {
158158
default = []
159159
}
160160

161-
variable "mountpoint_s3_csi_kms_ids" {
162-
description = "KMS CMK IDs to allow Mountpoint S3 CSI driver to download and upload Objects of a S3 bucket using `aws:kms` SSE"
161+
variable "mountpoint_s3_csi_kms_arns" {
162+
description = "KMS Key ARNs to allow Mountpoint S3 CSI driver to download and upload Objects of a S3 bucket using `aws:kms` SSE"
163163
type = list(string)
164164
default = []
165165
}

wrappers/iam-role-for-service-accounts-eks/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ module "wrapper" {
4848
load_balancer_controller_targetgroup_arns = try(each.value.load_balancer_controller_targetgroup_arns, var.defaults.load_balancer_controller_targetgroup_arns, ["arn:aws:elasticloadbalancing:*:*:targetgroup/*/*"])
4949
max_session_duration = try(each.value.max_session_duration, var.defaults.max_session_duration, null)
5050
mountpoint_s3_csi_bucket_arns = try(each.value.mountpoint_s3_csi_bucket_arns, var.defaults.mountpoint_s3_csi_bucket_arns, [])
51-
mountpoint_s3_csi_kms_ids = try(each.value.mountpoint_s3_csi_kms_ids, var.defaults.mountpoint_s3_csi_kms_ids, [])
51+
mountpoint_s3_csi_kms_arns = try(each.value.mountpoint_s3_csi_kms_arns, var.defaults.mountpoint_s3_csi_kms_arns, [])
5252
mountpoint_s3_csi_path_arns = try(each.value.mountpoint_s3_csi_path_arns, var.defaults.mountpoint_s3_csi_path_arns, [])
5353
node_termination_handler_sqs_queue_arns = try(each.value.node_termination_handler_sqs_queue_arns, var.defaults.node_termination_handler_sqs_queue_arns, ["*"])
5454
oidc_providers = try(each.value.oidc_providers, var.defaults.oidc_providers, {})

0 commit comments

Comments
 (0)