Support Multiple default Host OS Images per Product Version in Sumaform

[srbarrios]

Description:

Currently, Sumaform ties each product version (e.g. 5.0, 5.1, Head) to a single Host OS image (qcow2), with the possibility to override it via the environment's Terraform definition (see main.tf#L39). However, we need to support multiple images for each product version, specifically SLES and SLE Micro variants.

We want to:

• Allow configuring additional supported images per product version.
• Store this metadata in Sumaform, rather than relying only on overrides.
• Decide on a maintainable and clean approach to implement this flexibility.

This will give us more control and visibility over which images are officially supported per product version.

Proposals:

1. Define new product versions, so we can have a default image for each of them, example:

   variable "images" {
     default = {
       "uyuni-master"   = "leapmicro55o"
       "uyuni-released" = "leapmicro55o"
       "uyuni-pr"       = "leapmicro55o"
       "head-micro"           = "slmicro61o"
       "5.0-micro-released"   = "slemicro55o"
       "5.0-micro-nightly"    = "slemicro55o"
       "5.1-micro-released"   = "slmicro61o"
       "5.1-micro-nightly"    = "slmicro61o"
       "head-sles"           = "sles15sp7o"
       "5.0-sles-released"   = "sles15sp6o"
       "5.0-sles-nightly"    = "sles15sp6o"
       "5.1-sles-released"   = "sles15sp7o"
       "5.1-sles-nightly"    = "sles15sp7o"
     }
   }
   

   OR

   variable "images" {
     default = {
       "uyuni-master"   = "leapmicro55o"
       "uyuni-released" = "leapmicro55o"
       "uyuni-pr"       = "leapmicro55o"
       "head"           = "slmicro61o"
       "5.0-released"   = "slemicro55o"
       "5.0-nightly"    = "slemicro55o"
       "5.1-released"   = "slmicro61o"
       "5.1-nightly"    = "slmicro61o"
       "head-sles"           = "sles15sp7o"
       "5.0-sles-released"   = "sles15sp6o"
       "5.0-sles-nightly"    = "sles15sp6o"
       "5.1-sles-released"   = "sles15sp7o"
       "5.1-sles-nightly"    = "sles15sp7o"
     }
   }
   

2. We have defined somewhere all supported images for a particular version, so we validate the image passed on the terraform environment:

   variable "supported_images" {
     default = {
       "uyuni-master"   = [ "leapmicro55o" ]
       "uyuni-released" = [ "leapmicro55o" ]
       "uyuni-pr"       = [ "leapmicro55o" ]
       "head"           = [ "slmicro61o", "sles15sp7o" ]
       "5.0-released"   = [ "slemicro55o", "sles15sp6o" ]
       "5.0-nightly"    = [ "slemicro55o", "sles15sp6o" ]
       "5.1-released"   = [ "slmicro61o", "sles15sp7o" ]
       "5.1-nightly"    = [ "slmicro61o", "sles15sp7o" ]
     }
   }
   

[rjmateus]

I like the approach proposed on 1, since it makes it simpler for users, and avoids defining the image to be used.
We just need to double-check if it has any impact on the salt states.

[Bischoff]

I noticed a confusion when reading the remarks on my 5.1 PR.

We already do support multiple OS images per product version.
It's only that the default value is currently mandating SL Micro.
But nothing prevents you currently from using SLE, with an override.

As the title here encourages this confusion, I'll add "default" to the title.

[srbarrios]

As the title here encourages this confusion, I'll add "default" to the title.

Sure, thanks.
Just keep on the radar, that the refactor on this card aims not just have default images per product version, but take advantage of new product versions to simplify complexity in our Jinja statements, so we can differentiate code by product version, instead of evaluate it using a combination of other grains.