SonarCloud remove candidate rule: java:S1075 URIs should not be hardcoded

[CDellaGiusta]

This poll closes Friday, April 18th 2025.

Candidate rule for removal: java:S1075
Number of issues with this rule in Uyuni: 24
Rule: URIs should not be hardcoded
Software qualities impacted: MAINTAINABILITY
Why is this an issue:

Hard-coding a URI makes it difficult to test a program for a variety of reasons:

• path literals are not always portable across operating systems
• a given absolute path may not exist in a specific test environment
• a specified Internet URL may not be available when executing the tests
• production environment filesystems usually differ from the development environment

In addition, hard-coded URIs can contain sensitive information, like IP addresses, and they should not be stored in the code.
For all those reasons, a URI should never be hard coded. Instead, it should be replaced by a customizable parameter.

Further, even if the elements of a URI are obtained dynamically, portability can still be limited if the path delimiters are hard-coded.

This rule raises an issue when URIs or path delimiters are hard-coded.

Should it be removed?:
Most of the hardcoded stuff are fixed paths inside the filesystem. Since they are fixed, there should be no point into moving them in a configurable part.

All rule issues in Uyuni: https://sonarcloud.io/project/issues?languages=java&issueStatuses=OPEN%2CCONFIRMED&id=uyuni-project_uyuni&rules=java%3AS1075

Examples in our code:

public class OSImageStoreUtils {
  private static String osImageStorePath = "/srv/www/os-images/";

public class CatalinaAction extends RhnAction {
  private static final String LOGFILE_PATH = "/var/log/rhn/rhn_web_ui.log";

  // Static JSON files we parse
 private static File channelFamiliesJson = new File("/usr/share/susemanager/scc/channel_families.json");

[cbosdo]

Before removing it would probably make sense to go over the 24 instances to check if one could make sense