WIP: RBAC UI - component steps progressbar #10496

bisht-richa · 2025-06-24T10:06:21Z

What does this PR change?

Created new component steps progressbar
Created some UIs with dummy data for RBAC UI using steps progressbar component

GUI diff

DONE

Documentation

No documentation needed: add explanation. This can't be used if there is a GUI diff
No documentation needed: only internal and user invisible changes
Documentation issue was created: Link for SUSE Multi-Linux Manager contributors, Link for community contributors.
API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.
(OPTIONAL) Documentation PR
DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

No tests: add explanation
No tests: already covered
Unit tests were added
Cucumber tests were added
DONE

Links

Issue(s): #
Port(s): # add downstream PR(s), if any

DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

Re-run test "changelog_test"
Re-run test "backend_unittests_pgsql"
Re-run test "java_pgsql_tests"
Re-run test "schema_migration_test_pgsql"
Re-run test "susemanager_unittests"
Re-run test "javascript_lint"
Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

github-actions · 2025-06-24T10:06:31Z

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/10496/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/10496/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

cbbayburt · 2025-07-30T15:29:42Z

Some notes after initial review:

Add RBAC endpoint entries to DB
- /manager/admin/config/access-group, etc.
Rename menu item "Access Group" to "Access Control"
- Left menu bar
- URL '../access-group'
- Controller method: showAccessGroup
- Template file 'access-group.jade'
- .. etc

Role list page:

No pagination needed
Don't list built-in groups
- Remove 'Type' column

Namespace list table:

Search bar must work for descriptions as well

Add users step & add users tab in edit:

Only users from the same org as the AG should be listed
- Remove 'Organization' column

Signed-off-by: Pascal Arlt <[email protected]>

…d on selected org

…list

…disable parent if all children are disabled

Signed-off-by: Pascal Arlt <[email protected]>

cbbayburt

Thank you very much @bisht-richa, @parlt91. It looks very good overall.

I've also deployed and tested it, and everything works as expected.

Apart from my inline comments, here's a few notes I had when testing, mostly on the UX:

The text [API] looks a bit raw on the table. Maybe we should pick an icon for this instead.
Bug: when I go back to the first step and remove an item from "Copy permissions from" control, the permissions list is not recalculated.
After a series of searching and adding, it's easy to lose track of the overall selections. We need an overview of all the selections at the final step.
When you search for a namespace, the natural next step is always expanding some rows. We can automatically expand the whole filtered list after a search, and reduce the necessary steps taken by the user.
Apart from that, we could also use the usual "Expand/Collapse all" controls on the table.

cbbayburt · 2025-11-21T12:32:18Z

web/html/src/manager/admin/access-control/access-group-permissions.tsx

+  useEffect(() => {
+    if (!isLoading) {
+      setIsLoading(true);
+      getNamespaces(searchValue);
+    }
+  }, [searchValue]);


In this kind of search-as-you-type task, it's a good practice to limit the requests to the backend to prevent clogging up the network.

We already do this using the debounce utility from lodash. It wraps the method that does the API call and it waits for some milliseconds of inactivity before it calls the method. This way you avoid calling the API for every keystroke, and only do one call after the user pauses typing.

Here's an example usage (note the last arg: 100ms of wait time):

uyuni/web/html/src/manager/content-management/shared/components/panels/sources/channels/channels-selection.tsx

Lines 83 to 103 in fa55769

const onSearch = useCallback(

debounce((newSearch: string) => {

channelProcessor.setSearch(newSearch).then((newRows) => {

if (newRows) {

setRows(newRows);

}

if (newSearch) {

// Open all channels when search changes so visible child matches are also visible

setOpenRows(new Set(newRows?.map((row) => row.base.id)));

} else {

// When change is cleared, close all besides the selected base

const selectedBaseChannelId = channelProcessor.getSelectedBaseChannelId();

if (selectedBaseChannelId) {

setOpenRows(new Set([selectedBaseChannelId]));

}

}

});

}, 100),

[]

);

I think it should work if you wrap the getNamespace method like this and call it in useEffect.

cbbayburt · 2025-11-21T12:34:39Z

web/html/src/manager/admin/access-control/access-group-list.tsx

+    if (item.orgName === "-") {
+      return (
+        <div className="btn-group">
+          <Button className="btn-default btn-sm" icon="fa-user" />


This button has no function. I think we don't need it at all. I don't even remember why this was here in the first place (also below in the else block).

cbbayburt · 2025-11-21T12:35:55Z

web/html/src/manager/admin/access-control/access-group-list.tsx

+          <LinkButton
+            className="btn-default btn-sm"
+            icon="fa-pencil"
+            href={`/rhn/manager/admin/access-control/show-access-group/${item.id}`}
+          />


This button is missing a title

cbbayburt · 2025-11-21T12:52:27Z

java/code/src/com/suse/manager/webui/menu/MenuTree.java

+                            .withVisibility(adminRoles.get("satellite")))
+                    .addChild(new MenuItem("Access Control")
+                            .withPrimaryUrl("/rhn/manager/admin/access-control")


I think we can remove the item from here if there's no specific reason for it?

cbbayburt · 2025-11-21T12:55:06Z

java/spacewalk-java.changes.bisht-richa.steps-progressbar-component

@@ -0,0 +1 @@
+- Implemented a new StepsProgressBar component for managing RBAC.


The end user doesn't need to know about StepsProgressBar. Let's keep it simple. Maybe something like:

Suggested change

- Implemented a new StepsProgressBar component for managing RBAC.

- Implemented RBAC management UI

cbbayburt · 2025-11-21T12:59:33Z

java/code/src/com/redhat/rhn/domain/access/NamespaceFactory.java

+                .createNativeQuery("""
+                SELECT *
+                FROM access.namespace
+                WHERE :filter <% lower(namespace||description)


Maybe we should add a "." after the namespace (also to the index in the schema). Currently, "systemget_details" works, but "system.get_details" doesn't.

cbbayburt · 2025-11-24T11:45:43Z

...cewalk/upgrade/susemanager-schema-5.2.0-to-susemanager-schema-5.2.1/100-rbac-ui-mappings.sql

+INSERT INTO access.namespace (namespace, access_mode, description)
+    SELECT 'admin.access-control.access-group', 'R', 'List and detail custom access groups.'
+    WHERE NOT EXISTS (SELECT 1 FROM access.namespace WHERE namespace = 'admin.access-control.access-group' AND access_mode = 'R');
+
+INSERT INTO access.namespace (namespace, access_mode, description)
+    SELECT 'admin.access-control.access-group', 'W', 'Create, modify and delete custom access groups.'
+    WHERE NOT EXISTS (SELECT 1 FROM access.namespace WHERE namespace = 'admin.access-control.access-group' AND access_mode = 'W');


We don't plan to expand this feature much further so I think only 2 levels are enough for the namespace. Also I suggested "access" to be consistent with the api.access namespace.

Suggested change

INSERT INTO access.namespace (namespace, access_mode, description)

SELECT 'admin.access-control.access-group', 'R', 'List and detail custom access groups.'

WHERE NOT EXISTS (SELECT 1 FROM access.namespace WHERE namespace = 'admin.access-control.access-group' AND access_mode = 'R');

INSERT INTO access.namespace (namespace, access_mode, description)

SELECT 'admin.access-control.access-group', 'W', 'Create, modify and delete custom access groups.'

WHERE NOT EXISTS (SELECT 1 FROM access.namespace WHERE namespace = 'admin.access-control.access-group' AND access_mode = 'W');

INSERT INTO access.namespace (namespace, access_mode, description)

SELECT 'admin.access', 'R', 'List and detail custom access groups.'

WHERE NOT EXISTS (SELECT 1 FROM access.namespace WHERE namespace = 'admin.access-control.access-group' AND access_mode = 'R');

INSERT INTO access.namespace (namespace, access_mode, description)

SELECT 'admin.access', 'W', 'Create, modify and delete custom access groups.'

WHERE NOT EXISTS (SELECT 1 FROM access.namespace WHERE namespace = 'admin.access-control.access-group' AND access_mode = 'W');

Also: the data is missing in common/data/..

cbbayburt · 2025-11-24T11:48:53Z

web/spacewalk-web.changes.bisht-richa.steps-progressbar-component

@@ -0,0 +1 @@
+- Implemented a new StepsProgressBar component for managing RBAC.


The end user doesn't need to know about StepsProgressBar. Let's keep it simple. Maybe something like:

Suggested change

- Implemented a new StepsProgressBar component for managing RBAC.

- Implemented RBAC management UI

github-actions bot added java java_lint_checkstyle java_pgsql_tests API ui javascript_lint xmlrpc old-ui needs-translation labels Jun 24, 2025

parlt91 force-pushed the component-steps-progressbar branch from 89d5409 to 661a3c1 Compare July 29, 2025 07:55

github-actions bot added webapp data-model spark-router labels Jul 29, 2025

wweellddeerr force-pushed the component-steps-progressbar branch from 7693eef to 9a5b589 Compare August 14, 2025 13:45

github-actions bot added schema_migration_test_pgsql database schema_migration_test_oracle labels Aug 25, 2025

parlt91 force-pushed the component-steps-progressbar branch from e89309d to a155669 Compare September 5, 2025 10:41

bisht-richa force-pushed the component-steps-progressbar branch from 67c2ef3 to ef95129 Compare September 12, 2025 18:23

bisht-richa added 9 commits October 11, 2025 17:11

Added steps-progress-bar.tsx

ec022f3

Added details form

846c153

Created forms for steps

88b0943

Created UI for details, permission and users page

5c64523

Clean code

8eb648f

Added changelog and fix failing tests

13123d9

Fix sonarcloud error

d0e9778

Removed fixed offset for fulll height, fixed lints and other comments

e1da6b9

Fix lint

f7d8880

parlt91 and others added 26 commits October 11, 2025 17:11

Make Access Groups org specific

2ba67b7

Signed-off-by: Pascal Arlt <[email protected]>

Use TabContainer for editing access groups

d545048

Signed-off-by: Pascal Arlt <[email protected]>

Fix frontend lint

77586b6

Fix layout for edit access group

0bc2721

Replace hardcoded access groups with dynamic values from backend base…

a1f1059

…d on selected org

Display namespaces in hierarchical structure

8beb9bc

Standardize access control naming

de512a5

Remove server side pagination and built-in groups from access groups …

cd80f0b

…list

Prevent advancing with empty details

c03f4b3

Remove 'Organization' column from users table

9c0a920

Implement copy permissions from selected groups

29fdb88

Add unit tests for namespace tree helper

fe08337

Validate form before advance in details tab

e99a96c

Fix parent/child permissions selection to skip disabled children and …

d2c048d

…disable parent if all children are disabled

Fix edit permissions

3ea640b

Don't load groups list when editing

5eddb0e

Avoid duplicates when listing permissions to copy from

3d65466

Implement response error handling

3725508

Fix input height

b36afe8

Remove Add Permission button

65a8231

Fix list page URL

88698e4

Align access group endpoints under common prefix

a8ec2f4

Add RBAC mappings for RBAC UI

864f652

Remove console.log and include translation

42c4c02

Fix access group features for non-admin users

377aec3

Added filters, search and other UI improvements

55384eb

parlt91 force-pushed the component-steps-progressbar branch from ef95129 to c4e32a5 Compare October 11, 2025 15:12

Add fuzzy search to Namesapce & Permissions table

67c083d

Signed-off-by: Pascal Arlt <[email protected]>

parlt91 force-pushed the component-steps-progressbar branch from c4e32a5 to 67c083d Compare October 11, 2025 15:21

cbbayburt requested changes Nov 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WIP: RBAC UI - component steps progressbar #10496

WIP: RBAC UI - component steps progressbar #10496

Uh oh!

bisht-richa commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

cbbayburt commented Jul 30, 2025 •

edited

Loading

Uh oh!

cbbayburt left a comment

Uh oh!

cbbayburt Nov 21, 2025

Uh oh!

cbbayburt Nov 21, 2025

Uh oh!

cbbayburt Nov 21, 2025

Uh oh!

cbbayburt Nov 21, 2025

Uh oh!

cbbayburt Nov 21, 2025

Uh oh!

cbbayburt Nov 21, 2025

Uh oh!

cbbayburt Nov 24, 2025

Uh oh!

cbbayburt Nov 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	const onSearch = useCallback(
	debounce((newSearch: string) => {
	channelProcessor.setSearch(newSearch).then((newRows) => {
	if (newRows) {
	setRows(newRows);
	}

	if (newSearch) {
	// Open all channels when search changes so visible child matches are also visible
	setOpenRows(new Set(newRows?.map((row) => row.base.id)));
	} else {
	// When change is cleared, close all besides the selected base
	const selectedBaseChannelId = channelProcessor.getSelectedBaseChannelId();
	if (selectedBaseChannelId) {
	setOpenRows(new Set([selectedBaseChannelId]));
	}
	}
	});
	}, 100),
	[]
	);

		@@ -0,0 +1 @@
		- Implemented a new StepsProgressBar component for managing RBAC.

	- Implemented a new StepsProgressBar component for managing RBAC.
	- Implemented RBAC management UI

WIP: RBAC UI - component steps progressbar #10496

Are you sure you want to change the base?

WIP: RBAC UI - component steps progressbar #10496

Uh oh!

Conversation

bisht-richa commented Jun 24, 2025

What does this PR change?

GUI diff

Documentation

Test coverage

Links

Changelogs

Re-run a test

Before you merge

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

cbbayburt commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cbbayburt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cbbayburt commented Jul 30, 2025 •

edited

Loading