Uyuni config auto repo sync

[rjmateus]

What does this PR change?

Allow configuration at channel level if it should be picked by the recurrent taskomatic mgr-sync, which run synchronization once per day.

Channels can still be synchronized manually by users if needed.
The synchronization status is shown in the UI. Changing the flag is only available through the API.

This feature is useful because it allows disble outsync on some channels that know they will not receive any more updates, like the pool channels.

GUI diff

No difference.

Before:

After:

• DONE

Documentation

• No documentation needed: It will need documentation on how tho use it.

• No documentation needed: only internal and user invisible changes

• Documentation issue was created: Link for SUSE Multi-Linux Manager contributors, Link for community contributors.

• API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.

• (OPTIONAL) Documentation PR

• DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

• No tests: add explanation

• No tests: already covered

• Unit tests were added

• Cucumber tests were added

• DONE

Links

Issue(s): #
Port(s): # add downstream PR(s), if any

• DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

• No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• Re-run test "changelog_test"
• Re-run test "backend_unittests_pgsql"
• Re-run test "java_pgsql_tests"
• Re-run test "schema_migration_test_pgsql"
• Re-run test "susemanager_unittests"
• Re-run test "javascript_lint"
• Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

[github-actions]

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/10897/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/10897/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary_parallel.yml?query=event%3Aschedule

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary.yml?query=event%3Aschedule

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

[mcalmer]

I have a problem to understand the background of this and what you want to achieve.

1. Vendor Channels are by default always auto synced over night.
2. we have an option for custom channel to also sync over night together with the vendor channels (rhn_java.conf java.unify_custom_channel_management = true)

Now an auto_sync configuration is added. I think you can only change it when it is a custom channel.
I could not find the code which obsolete the current configuration value. We still have the check for
"isCustomChannelManagementUnificationEnabled()" .

Is it planned to make this configurable for vendor channels as well?
Where should this go?

[rjmateus]

I have a problem to understand the background of this and what you want to achieve.

@mcalmer, my goal with these changes is to allow for the configuration in any channel, vendor and custom ones.
This should work side by side with the existing flag of java.unify_custom_channel_management.

My idea is that some channels may not need to get updates during the night, even vendor ones (think about the pool channels, for example). By synchronizing it, we are putting a load on the server for the mgr_sync task and the repo metadata generation task (even if no packages get downloaded). This way, we can skip individual channels and reduce the load.

Another topic that we can look at, is skip channel metadata generation if no packages have changed, which would also reduce the load.

Michael, any thoughts on this?

[rjmateus]

Thank you for the review @mackdk , I think I have addressed all the comments. Cheers

[mackdk]

LGTM. Not sure why SonarCloud is picking so many errors on unrelated files though

[rjmateus]

@mackdk sorry to trigger the review again but I have forced push the name of the sql script and that cleared the approval.

[rjmateus]

@admd should I port this PR to 5.1? Or should it land only in uyuni and later in 5.2?