Better tests

Author: stalgiag

client/tests/TestQueue/OnHoldButton.test.jsx

@@ -384,6 +384,81 @@ describe('Test Queue admin traits when reports exist', () => {
       ).toBe(true);
     });
   });
+
+  it('allows admin to toggle On hold and shows pill in Status', async () => {
+    await getPage({ role: 'admin', url: '/test-queue' }, async page => {
+      const sectionButtonSelector = 'button#disclosure-btn-modal-dialog-0';
+      const tableSelector =
+        'table[aria-label="Reports for Modal Dialog Example V24.06.07 in draft phase"]';
+
+      await page.waitForSelector(sectionButtonSelector);
+      await page.click(sectionButtonSelector);
+      await page.waitForSelector(tableSelector);
+
+      // Work with first row in the table body
+      const selectors = await page.$eval(tableSelector, el => {
+        const firstRow = el.querySelector('tbody tr');
+        const cells = firstRow.querySelectorAll('td');
+        return {
+          statusCellText: cells[3].innerText,
+          actionsCellSelector: 'tbody tr td:nth-child(5)'
+        };
+      });
+
+      // Ensure not on hold initially
+      expect(selectors.statusCellText.includes('On hold')).toBe(false);
+
+      // Click the toggle to put on hold
+      await page.$eval(
+        `${tableSelector} ${selectors.actionsCellSelector}`,
+        el => {
+          const btn = Array.from(el.querySelectorAll('button')).find(b =>
+            /Put on hold/i.test(b.innerText)
+          );
+          if (btn) btn.click();
+        }
+      );
+
+      await page.waitForNetworkIdle();
+
+      // Verify pill and button label
+      const [statusTextAfter, toggleLabelAfter] = await page.$eval(
+        tableSelector,
+        el => {
+          const firstRow = el.querySelector('tbody tr');
+          const cells = firstRow.querySelectorAll('td');
+          const statusText = cells[3].innerText;
+          const actionsCell = cells[4];
+          const btn = Array.from(actionsCell.querySelectorAll('button')).find(
+            b => /Ready for testing|Put on hold/i.test(b.innerText)
+          );
+          return [statusText, btn ? btn.innerText : ''];
+        }
+      );
+
+      expect(statusTextAfter.includes('On hold')).toBe(true);
+      expect(/Ready for testing/i.test(toggleLabelAfter)).toBe(true);
+
+      // Toggle back to ready
+      await page.$eval(tableSelector, el => {
+        const firstRow = el.querySelector('tbody tr');
+        const actionsCell = firstRow.querySelectorAll('td')[4];
+        const btn = Array.from(actionsCell.querySelectorAll('button')).find(b =>
+          /Ready for testing/i.test(b.innerText)
+        );
+        if (btn) btn.click();
+      });
+      await page.waitForNetworkIdle();
+
+      const statusTextFinal = await page.$eval(tableSelector, el => {
+        const firstRow = el.querySelector('tbody tr');
+        const cells = firstRow.querySelectorAll('td');
+        return cells[3].innerText;
+      });
+
+      expect(statusTextFinal.includes('On hold')).toBe(false);
+    });
+  });
 });
 
 describe('Test Queue tester traits when reports exist', () => {

client/tests/TestRun/OnHoldModal.test.jsx

@@ -603,6 +603,92 @@ describe('Test Run when signed in as tester', () => {
     });
   });
 
+  it('enforces read-only and shows on-hold modal when report is On hold', async () => {
+    // Ensure the report is On hold as admin first, then switch to tester in same page
+    await getPage({ role: 'admin', url: '/test-queue' }, async page => {
+      const sectionButtonSelector = 'button#disclosure-btn-modal-dialog-0';
+      const tableSelector =
+        'table[aria-label="Reports for Modal Dialog Example V24.06.07 in draft phase"]';
+
+      await page.waitForSelector(sectionButtonSelector);
+      await page.click(sectionButtonSelector);
+      await page.waitForSelector(tableSelector);
+
+      // Toggle to On hold if not already
+      const toggleWasClicked = await page.$eval(tableSelector, el => {
+        const firstRow = el.querySelector('tbody tr');
+        const actionsCell = firstRow.querySelectorAll('td')[4];
+        const btn = Array.from(actionsCell.querySelectorAll('button')).find(b =>
+          /Put on hold|Ready for testing/i.test(b.innerText)
+        );
+        if (!btn) return false;
+        const isOnHold = /Ready for testing/i.test(btn.innerText);
+        if (!isOnHold) {
+          btn.click();
+          return true;
+        }
+        return false;
+      });
+      if (toggleWasClicked) await page.waitForNetworkIdle();
+
+      // Verify status shows On hold
+      const statusText = await page.$eval(tableSelector, el => {
+        const firstRow = el.querySelector('tbody tr');
+        const statusCell = firstRow.querySelectorAll('td')[3];
+        return statusCell.innerText;
+      });
+      expect(statusText.includes('On hold')).toBe(true);
+
+      // Sign in as tester within same session/transaction
+      await page.evaluate('signMeInAsTester("joe-the-tester")');
+      await page.waitForSelector('::-p-text(Signed in)');
+
+      // Expand and assign self
+      await page.waitForSelector(sectionButtonSelector);
+      await page.click(sectionButtonSelector);
+      await page.waitForSelector(tableSelector);
+      await page.$eval(tableSelector, el => {
+        // First button is Assign Yourself
+        el.querySelector('button').click();
+      });
+      await page.waitForNetworkIdle();
+      await page.waitForSelector('::-p-text(Unassign Yourself)');
+
+      // Start testing
+      await page.waitForSelector('a[role="button"] ::-p-text(Start Testing)');
+      await page.click('a[role="button"] ::-p-text(Start Testing)');
+      await page.waitForNavigation({
+        waitUntil: ['domcontentloaded', 'networkidle0']
+      });
+
+      // Wait for Test Run to render
+      await page.waitForSelector('h1 ::-p-text(Test 1:)');
+
+      // On hold modal should be visible
+      await page.waitForSelector('::-p-text(On hold)');
+
+      // Submit button should be disabled
+      await page.waitForSelector('button ::-p-text(Submit Results)');
+      const submitDisabled = await page.$eval(
+        'button[class="btn btn-primary"] ::-p-text(Submit Results)',
+        el => el.closest('button').disabled
+      );
+      expect(submitDisabled).toBe(true);
+
+      // Start Over should be disabled
+      const startOverDisabled = await page.$eval(
+        'button ::-p-text(Start Over)',
+        el => el.closest('button').disabled
+      );
+      expect(startOverDisabled).toBe(true);
+
+      // Close label should be present (not Save and Close)
+      await page.waitForSelector('button ::-p-text(Close)');
+      const hasSaveAndClose = await page.$('button ::-p-text(Save and Close)');
+      expect(hasSaveAndClose).toBeNull();
+    });
+  });
+
   it('focuses first assertion radio button when only top output is filled', async () => {
     await getPage({ role: 'tester', url: '/test-queue' }, async page => {
       await assignSelfAndNavigateToRun(page);

client/tests/e2e/TestQueue.e2e.test.js

@@ -576,6 +576,7 @@ describe('graphql', () => {
               startedAt
               completedAt
             }
+            onHold
             isRerun
             percentComplete
             metrics
@@ -756,6 +757,12 @@ describe('graphql', () => {
                 locationOfData
               }
             }
+            setOnHold: testPlanReport(id: 1) {
+              __typename
+              setOnHold(onHold: true) {
+                locationOfData
+              }
+            }
             deleteRun: testPlanReport(id: 2) {
               __typename
               deleteTestPlanRun(userId: 2) {