Skip to content

Save impression method does not validate histogramIndex against maximum histogram size #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
apasel422 opened this issue Jun 4, 2025 · 0 comments · May be fixed by #198
Open

Save impression method does not validate histogramIndex against maximum histogram size #197

apasel422 opened this issue Jun 4, 2025 · 0 comments · May be fixed by #198
Assignees
@apasel422
Labels
editorial An issue that does not affect the design of the protocol; does not require consensus

Comments

@apasel422
Copy link
Collaborator

IIUC it should probably be checked against the same implementation-defined maximum used in measureConversion in order to avoid storing impressions that can never be used to fill a histogram (Step 5 here).
@apasel422 apasel422 self-assigned this Jun 4, 2025
@apasel422 apasel422 added the editorial An issue that does not affect the design of the protocol; does not require consensus label Jun 4, 2025
@apasel422 apasel422 linked a pull request Jun 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apasel422 apasel422

Labels
editorial An issue that does not affect the design of the protocol; does not require consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reject impressions with histogramIndex >= maximum histogram size apasel422/ppa-api
1 participant
@apasel422