Skip to content

Final version has obvious mistakes in conditions #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VolodymyrLapan opened this issue May 14, 2025 · 2 comments
Open

Final version has obvious mistakes in conditions #721

VolodymyrLapan opened this issue May 14, 2025 · 2 comments

Comments

@VolodymyrLapan
Copy link

VolodymyrLapan commented May 14, 2025

Hello,

Your CG-FINAL-onix-techniques document contains following errors:

  1. In condition
    IF unknown_motion_simulation_hazard:
    THEN display "Motion simulation hazards not known"[ID: hazards-motion-unknown].

    Variable definition for unknown_motion_simulation_hazard does not exist.

  2. In condition
    IF no_motion_simulation_hazard:
    THEN display "No motion simulation hazards"[ID: hazards-motion-none].

    Variable definition for no_motion_simulation_hazard does not exist.

  3. In condition
    IF NOT (math_formula_as_mathml OR math_formula_as_latex OR (contains_math_formula AND short_textual_alternative_images) OR
    chemical_formula_as_mathml OR charts_diagrams_as_non_graphical_data OR full_alternative_textual_descriptions OR closed_captions OR
    open_captions OR transcript):
    THEN either omit this display field if metadata is missing or display "No information is available"[ID: rich-content-unknown].

    Variable definition for short_textual_alternative_images and contains_math_formula does not exist.

And please, add some explanation how things like normalize-space() or (@lang|ancestor::*/@lang)[last() should work, most parsers does not support it. We need to know how to implement these functions.

Thanks

@mattgarrish
Copy link
Member

mattgarrish commented May 22, 2025

1. Variable definition for unknown_motion_simulation_hazard does not exist.
2. Variable definition for no_motion_simulation_hazard does not exist.

These look like simple typos. Maybe from copying from the epub techniques. The variables are unknown_motion_hazard and no_motion_hazard everywhere else.

3. Variable definition for short_textual_alternative_images and contains_math_formula does not exist.

This one I'm not sure about. @gregoriopellegrino should this part of the test be removed or are there variable definitions missing?

normalize-space() or (@lang|ancestor::*/@lang)[last()

These are xpath expressions. normalize-space trims and compacts whitespace within the given value (the text content of the selected node).

The node selector gets the language declaration that is currently in scope for the element. That will either come from a lang attribute on the selected node, if there is one, or the nearest ancestor element that has a lang attribute. The selector gets all of them and the last() call returns the one nearest to the element.

gregoriopellegrino added a commit that referenced this issue Jun 2, 2025
@gregoriopellegrino
Copy link
Collaborator

May you please check #727 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants