Skip to content

Inconsistent state when using browser history after expanding all sections #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kfranqueiro opened this issue Jun 3, 2025 · 0 comments · May be fixed by #285
Open

Inconsistent state when using browser history after expanding all sections #284

kfranqueiro opened this issue Jun 3, 2025 · 0 comments · May be fixed by #285

Comments

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Jun 3, 2025

Steps to reproduce

  1. Click Expand all sections
  2. Click any section in the Contents tab
  3. Press the back button

FWIW, judging by the old changelog, this may have been broken for nearly a decade. However, this is now additionally reproducible on the latest build by clicking any anchor link that appears within an individual section's text, which happens in e.g. 1.1.1's Sufficient Techniques.

Expected Behavior

  • You end up at the top of the page with everything still expanded

Actual Behavior

  • You end up at the top of the page but techniques and "About & How to Use" are collapsed; interestingly, full descriptions are still expanded.
  • The page is clearly out of sync:
    • There is still a large gap from where "Show About & How to Use" appeared when it was open
      • This issue can also be reproduced with specifically only this section, if you replace step 1 above with clicking "Show About & How to Use"
    • The button to expand/collapse all sections still says "collapse", not "expand"; you must click it twice to get to the state you were in before

Cause

I notice that if you expand individual techniques sections one-by-one, it seems to register in the query string, whereas the expand all toggle does not. I suspect something that happens in/from applyurl is not taking the "all" toggle into account, and wonder if that toggle should also somehow be represented in the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant