fix #2025: the -o argument of asymptote takes the basename of the output file path instead of the actual path now, so if we pass foo.png to -o, we will get foo.png.png

to fix this problem, we check if foo.png exists; if not, check foo.png.png

Author: yihui

.github/CONTRIBUTING.md

@@ -16,25 +16,6 @@ To make sure you did not break anything, you need to run tests, which are
 done through the [**testit**](http://cran.rstudio.com/package=testit)
 package. If you added any features, add your own tests in `tests/testit/`.
 
-## Travis CI
-
-If you are lazy or do not understand what I said above, just push commits to
-your repo, submit a PR, and wait for a few minutes.
-[Travis CI](http://yihui.name/en/2013/04/travis-ci-general-purpose/) will run
-the tests automatically. If your pull request passes the tests, you see
-green check marks, otherwise you see red crosses, and you will probably get
-email notifications as well.
-
-- [An example PR that passed the
-  check](https://github.com/yihui/knitr/pull/852/commits)
-- [An example PR that failed](https://github.com/yihui/knitr/pull/832/commits)
-
-When your PR does not pass the check, you need to click on the red cross to see
-details. There are two sets of tests: `R CMD check` on the package source, as
-well as the test on examples. The former is basically the unit tests, and the
-latter is to make sure your changes does not break my existing examples in the
-[knitr-examples](https://github.com/yihui/knitr-examples).
-
 ## roxygen2 documentation
 
 If your changes involve the roxygen2 documentation, please run `Rd2roxygen::rab('.')` to generate the Rd files.

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: knitr
 Type: Package
 Title: A General-Purpose Package for Dynamic Report Generation in R
-Version: 1.51.1
+Version: 1.51.2
 Authors@R: c(
     person("Yihui", "Xie", role = c("aut", "cre"), email = "[email protected]", comment = c(ORCID = "0000-0003-0645-5666", URL = "https://yihui.org")),
     person("Abhraneel", "Sarma", role = "ctb"),

NAMESPACE

@@ -152,6 +152,7 @@ import(grDevices)
 import(graphics)
 import(stats)
 import(utils)
+importFrom(xfun,file_exists)
 importFrom(xfun,file_ext)
 importFrom(xfun,file_string)
 importFrom(xfun,html_escape)

NEWS.md

@@ -1,5 +1,8 @@
 # CHANGES IN knitr VERSION 1.52
 
+## BUG FIXES
+
+- Due to a change in Asymptote, the output file may not be recognized or included correctly (thanks, @DeliciousRoastPotato @shangeconnew, #2025).
 
 # CHANGES IN knitr VERSION 1.51
 
@@ -9,7 +12,7 @@
   - `knit()` produces 'knitr processing' and 'knitr output' spans when starting and finishing an operation
   - `knit()` produces 'knit' spans for each chunk, recording attributes such as the label and knit engine
 
-- Added support for hooks that get executed before and after knitting. To register a hook before knitting starts, use `knitr::knit_hooks$set(before.knit = function() {})`. Similarly, the hook `after.knit` can be registered and will be executed after knitting is finished.
+- Added support for hooks that get executed before and after knitting (thanks, @cderv #2223, @arnaudgallou #2419). To register a hook before knitting starts, use `knitr::knit_hooks$set(before.knit = function() {})`. Similarly, the hook `after.knit` can be registered and will be executed after knitting is finished.
 
 ## BUG FIXES
 

R/engine.R

@@ -403,7 +403,13 @@ eng_plot = function(options) {
     output = function(options, code, output, file) {
       extra = if (options$eval) {
         # move the generated plot (with a temp filename) to fig.path
-        f1 = with_ext(file, ext)
+        if (!file_exists(f1 <- with_ext(file, ext))) {
+          # asymptote may geneate file.ext.ext (see #2025)
+          if (cmd == 'asy') f1 = paste0(f1, '.', ext)
+        }
+        if (!file_exists(f1)) stop(
+          'The command did not generate the expected plot file: ', f1
+        )
         f2 = paste(fig_path(), ext, sep = '.')
         xfun::dir_create(dirname(f2))
         unlink(f2)

R/package.R

@@ -26,7 +26,7 @@
 #'   FAQ's: \url{https://yihui.org/knitr/faq/}
 #' @importFrom xfun file_ext html_escape is_windows loadable parse_only
 #'   sans_ext try_silent with_ext read_utf8 write_utf8 file_string
-#'   is_R_CMD_check is_abs_path
+#'   is_R_CMD_check is_abs_path file_exists
 '_PACKAGE'
 
 .knitEnv = new.env()

R/utils-conversion.R

@@ -115,7 +115,7 @@ rnw2pdf = function(
   # On Windows, when tweaking the content, users may forget to close the PDF
   # file (thus can't be written). Since knitting may take quite some time, it's
   # better to check the write permission of the output file in advance.
-  if (xfun::file_exists(output) && !file.remove(output)) stop(
+  if (file_exists(output) && !file.remove(output)) stop(
     "The file '", output, "' cannot be removed (may be locked by a PDF reader)."
   )
   old = opts_chunk$set(error = error)