Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mobile devices #22

Open
MajorMeerkatThe3rd opened this issue Aug 3, 2023 · 5 comments
Open

Support for mobile devices #22

MajorMeerkatThe3rd opened this issue Aug 3, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@MajorMeerkatThe3rd
Copy link

First of all, amazing what you have been doing here! Thank you for all your work here.

I was wondering if there will also be support for this on mobile. I tested with the AO effects and there seem to be issues on my Android device. Do you know a workaround for this?

@kitaedesigns
Copy link

Doesn't seem to work on iOS Safari either.

@0beqz
Copy link
Owner

0beqz commented Aug 29, 2023

Thanks! Yes, mobile support is always a priority. There are always platform-specific issues when implementing features so I have to look into these bugs before releasing new versions.
Which AO effect are you using? If you are using SSAO (N8AO) then you should use the one from the N8's repository: https://github.com/N8python/n8ao as it's going to be deprecated in this repo.
But I'll also look into the issues with the AO effect before releasing.

@0beqz 0beqz added the bug Something isn't working label Aug 29, 2023
@MajorMeerkatThe3rd
Copy link
Author

Thanks for looking into this @0beqz!

I noticed this issue for both approaches. I think it might have something to do with how the depth is computed.

@adamDeluxe
Copy link

For some reason seems to work fine on an iphone 8 plus running ios 15.5 but not a 13 pro running 17.1

@MajorMeerkatThe3rd
Copy link
Author

@0beqz The issue seems to be with devices that only support WebGL1. On some iOS devices with Chrome, there is still WebGL1 used. And of course there some of the shader code doesn't work as it expects GLSL3 functions to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants