fix meshes being visible false, fix noise banding on planes #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DanielBelmes
commented
Jan 30, 2024
|
|
||
| float roughnessRadius = mix(mat.roughness * mat.roughness, 1., specularPhi); | ||
|
|
||
| float r = flatness * radius * exp(-max(inputs[0].a, inputs[1].a) * 0.01); |
Author
There was a problem hiding this comment.
I saw this was added but the inputs[0].a isn't guaranteed defined at this point and I was too lazy to figure out why. So I just removed this change for now.
Owner
|
Hey, thanks a lot for the PR. I'll look into the changes later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to just use this as an indicator of these bugs. I don't know if you've managed to test with these issues. Furthermore The SSG/SSR effect isn't super compatible with other effects as it doesn't adhere to the combined effect pipeline system they have in place. The InputColor is completely ignored. I have done modifications locally as well that uses some of the input Color but it breaks the example. But works in all our scenes.