Skip to content

Separate Directory and DirectoryBackground #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

archit9169
Copy link

No description provided.

Add background option for separate directory and background.
Change target name from directorybackground to only background to keep naming consistent across the source code.
@bastianeicher
Copy link
Member

This would probably work. The unit tests only failed because of an unrelated issue with desktop integration on Linux, which I've fixed in he meantime.

However, I'm not really sure if this feature will be useful. While some applications may only add Directory and not Directory\Background context menu entries, I believe this is usually just an oversight or a holdover from older Windows versions that did not support Directory\Background yet.

Is there any harm to always adding the entry to both? This would keep the feed format simpler, also avoiding the need to update to update the "capabilities" caspecification and existing feeds on apps.0install.net

@archit9169
Copy link
Author

archit9169 commented Aug 1, 2020

I was thinking what if a program does not needs to add that context menu entry. Because in some cases those entries are not very useful, and personally i like to keep thing organised, even context menu entries. But on the other hand i am not sure if other users really care about that and it might be only me. Is there any other way that users like me can get an option to choose either one or both without changing the current implementation?

What about an extra tag in capabilities named "Exclude" or something that can be false by default and when enabled or made true, it excludes the background from directory?

Eg:

if(ExcludeBackground) {
ContextMenuTarget.Directories => new[] {RegKeyClassesDirectories},
} else {
ContextMenuTarget.Directories => new[] {RegKeyClassesDirectories, RegKeyClassesDirectories + @"\Background"},
}

@bastianeicher bastianeicher force-pushed the master branch 7 times, most recently from edd9c81 to 8570d84 Compare August 8, 2020 11:37
@bastianeicher bastianeicher force-pushed the master branch 2 times, most recently from 21b37a5 to 555e6f3 Compare August 16, 2020 11:51
@bastianeicher bastianeicher force-pushed the master branch 2 times, most recently from fdbd739 to 22e3618 Compare November 10, 2020 09:54
@bastianeicher bastianeicher force-pushed the master branch 6 times, most recently from 4312137 to 8792643 Compare December 4, 2020 21:11
@bastianeicher bastianeicher force-pushed the master branch 4 times, most recently from d0d4634 to 17c4079 Compare December 22, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants