Switch to CGO-Free SQLite drive #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0x2E - Cool, yes that works! I tested a merge of the two here and it builds successfully on NixOS: https://github.com/mtlynch/fusion/tree/static-build-no-cgo I'm happy to see CGO go away, but another alternative is that we could adjust scripts.sh to only do static linking on non-Darwin systems. |
|
Thanks for the testing.
CGO also makes cross-compiling CI tough, so let's fix it all in one go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current SQLite driver uses CGO, which makes cross-compilation and static build (#36) difficult. The new CGO-free driver is slower, but it's fine for small projects.
Context: