Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from UWP to the Windows App SDK #316

Merged
merged 38 commits into from
Oct 16, 2022
Merged

Migrate from UWP to the Windows App SDK #316

merged 38 commits into from
Oct 16, 2022

Conversation

0x5bfa
Copy link
Owner

@0x5bfa 0x5bfa commented Oct 4, 2022

Description and Motivation

We are very exciting to do this! Recently, there are more projects migrating from UWP to the WASDK, and at the same time, we are continueing to introduce this migration to make it easier to access local files and for the WebView2, which is completely new from legacy WebView.

Advisories and Breaking Changes

This will be a breaking change that we've created ever. So when this ship to the main branch, version will be bumped to v0.5.0

Related/Fixed issues

Progress

  • Update FluentHub.Uwp csproj file to use WASDK
  • Update namespace Windows.UI to Microsoft.UI
  • Update namespace Windows.Toolkit to CommunityToolkit
  • Clean up namespaces in all C# files
  • Clean up namespaces in all XAML files
  • Remove dependencies that doesn't support .net6
  • Update WebView to WebView2
  • Clean up all project files
  • Add an alternative solution to regacy WebView
  • Update namespace from FluentHub.Uwp to FluentHub.App
  • Fix WinUI 3.0 compatible issues

Known Issues

  • TabView items doesn't display their icons.

What's New

  • Update item DataTemplate of MainPage's NavigationView
  • Add details sidebar in single Issue/PR page
  • Update all of item DataTemplates of the Issue/PR's timeline
  • Improve UI of the user status block
  • Add new extension method to access localization resources
  • Add new extension method to handle resize of WebView2

What's Changed

  • Updated the project from UWP to WASDK app(FluentHub.App.csproj)
  • Update namespace 'FluentHub.Uwp' to 'FluentHub.App'
  • Update WebView to WebView2
  • Remove all 'muxc' namespace mapping in XAML
  • Remove all 'muxc' namespace alias in both of XAML and C#
  • Update namespace 'Windows.UI' to 'Microsoft.UI' in both of XAML and C#
  • Update namespace 'Microsoft.Toolkit' to 'CommunityToolkit' in both of XAML and C#

@0x5bfa 0x5bfa added type/feature-request This issue is a feature request. breaking change labels Oct 4, 2022
@0x5bfa 0x5bfa added this to the Post v1 milestone Oct 4, 2022
@0x5bfa 0x5bfa self-assigned this Oct 4, 2022
@Lamparter Lamparter self-assigned this Oct 4, 2022
@Lamparter Lamparter mentioned this pull request Oct 4, 2022
Copy link
Collaborator

@Lamparter Lamparter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress! LGTM.

@0x5bfa 0x5bfa requested a review from Lamparter October 10, 2022 12:06
@0x5bfa 0x5bfa marked this pull request as ready for review October 10, 2022 12:29
@Lamparter
Copy link
Collaborator

@onein528 Why does this close #253?

Lamparter
Lamparter previously approved these changes Oct 10, 2022
@github-actions github-actions bot added the triage/approved This PR has been approved by the team. label Oct 10, 2022
@0x5bfa
Copy link
Owner Author

0x5bfa commented Oct 10, 2022

@onein528 Why does this close #253?

Ooops, right. I removed this part.

@0x5bfa
Copy link
Owner Author

0x5bfa commented Oct 10, 2022

I am going to clean up. Some of page doesn't have full compatible. so the time when this PR closes will be after Friday.

@Lamparter Lamparter dismissed their stale review October 11, 2022 06:14

@onein528: "I am going to clean up. Some of page doesn't have full compatible. so the time when this PR closes will be after Friday."

@0x5bfa 0x5bfa removed the triage/approved This PR has been approved by the team. label Oct 11, 2022
Copy link
Collaborator

@Lamparter Lamparter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Icons should appear here.


image
WinUI must put some sort of hidden element here because the buttons cannot be clicked unless you hover over the very bottom of them; buttons and other controls should be able to be clicked from all parts of them.

@0x5bfa
Copy link
Owner Author

0x5bfa commented Oct 14, 2022

I know those two issues.

In second one, I cannot figure out how to fix it.
FYI, second one was fixed already in Files.

@Lamparter
Copy link
Collaborator

Lamparter commented Oct 14, 2022

In second one, I cannot figure out how to fix it. FYI, second one was fixed already in Files.

@yaichenbaum

image
WinUI must put some sort of hidden element here because the buttons cannot be clicked unless you hover over the very bottom of them; buttons and other controls should be able to be clicked from all parts of them.

@yaira2
Copy link

yaira2 commented Oct 14, 2022

The title bar drag regions are a bit buggy on WinAppSdk, it might be worth opening an issue on the wasdk repository. In the meantime, you can workaround this by using the SetDragRectangles api.
https://github.com/files-community/Files/blob/main/src/Files.App/Views/MainPage.xaml.cs#L156

@0x5bfa
Copy link
Owner Author

0x5bfa commented Oct 14, 2022

Thank you for that API. @DeveloperWOW64 I will implement it.

@Lamparter
Copy link
Collaborator

DeveloperWOW64 dismissed their stale review

Resolved

Oops..

@0x5bfa
Copy link
Owner Author

0x5bfa commented Oct 16, 2022

I'm still working on this! Godamn.

image

microsoft/microsoft-ui-xaml#7837

Copy link
Collaborator

@Lamparter Lamparter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that API. @DeveloperWOW64 I will implement it.

@onein528 I don't see the API implemented.

An issue where the pointer could not recognize a part of the controls extended to the area of the titlebar
@Lamparter Lamparter dismissed their stale review October 16, 2022 15:10

(Partially) Resolved

@0x5bfa
Copy link
Owner Author

0x5bfa commented Oct 16, 2022

Known Issues

  • TabView items doesn't display their icons.

What's New

  • Update item DataTemplate of MainPage's NavigationView
  • Add details sidebar in single Issue/PR page
  • Update all of item DataTemplates of the Issue/PR's timeline
  • Improve UI of the user status block
  • Add new extension method to access localization resources
  • Add new extension method to handle resize of WebView2

What's Changed

  • Updated the project from UWP to WASDK app(FluentHub.App.csproj)
  • Update namespace 'FluentHub.Uwp' to 'FluentHub.App'
  • Update WebView to WebView2
  • Remove all 'muxc' namespace mapping in XAML
  • Remove all 'muxc' namespace alias in both of XAML and C#
  • Update namespace 'Windows.UI' to 'Microsoft.UI' in both of XAML and C#
  • Update namespace 'Microsoft.Toolkit' to 'CommunityToolkit' in both of XAML and C#

ioapiset
ioapiset approved these changes Oct 16, 2022
@0x5bfa 0x5bfa requested a review from Lamparter October 16, 2022 15:21
@github-actions github-actions bot added the triage/approved This PR has been approved by the team. label Oct 16, 2022
Copy link
Collaborator

@Lamparter Lamparter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏 WELL DONE

I certify the readiness of this new and constantly pioneering Pull Request; I review it and approve it in full.

🎉🎉🎉 What an achievement!!! @0x5bfa the work you have done is amazing and deserves merit.
On behalf of the entire @FluentHub community, thank you.

@Lamparter Lamparter merged commit aec7b87 into main Oct 16, 2022
@Lamparter Lamparter deleted the wasdk branch October 16, 2022 15:23
@Lamparter Lamparter removed the triage/needs-review This PR needs review from the team. label Oct 16, 2022
@Lamparter Lamparter mentioned this pull request Jul 22, 2024
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/approved This PR has been approved by the team.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants