Add basic support for Bun package manager #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x80
requested changes
Aug 1, 2024
There was a problem hiding this comment.
Great to see that adding (partial) support was so easy. It seems like your editor didn't execute prettier on save, so please run the format script.
Also, it would be great if you could add something to the readme here:
- Should work with any package manager, and tested with NPM, PNPM, and Yarn
(both classic and modern)
0x80
approved these changes
Aug 4, 2024
|
Thanks for your contribution. The formatting check still fails on the readme, but I'll fix that after merging. I will release an updated version soon. |
|
Sorry I didn't realise there's linting on the readme! I'm a bit of an open source contribution novice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I was able to successfully isolate and deploy a Firebase Functions project inside a Bun (v1.1.20) workspace by making these changes to
isolate-package. The output lockfile falls back to NPM - which is fine for Firebase Functions, since I don't think Bun is supported anyway.