-
Notifications
You must be signed in to change notification settings - Fork 44
Remove low-level Miden SDK WIT interfaces in favor of rlib stub library #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
@bitwalker I've tried with |
54c2d6a
to
ee2f000
Compare
daedd7d
to
b171302
Compare
instead of WIT interface
instead of the WIT interface
when deciding if we need to rebuild.
instead of the WIT interface.
instead of the WIT interface
…g from the `cargo-miden` to the `miden-stdlib-sys`, `miden-base-sys` and `miden-sdk-alloc` crates build.rs build script.
1688716
to
23a1345
Compare
Add error handling instead of panics.
…ing WIT imports anymore #341
@bitwalker I've tried putting the absolute path in
Disabling |
@bitwalker WARNING: When this PR is merged the new |
Close #532
Close #531
Close #341
Corresponding template repo PR - 0xMiden/rust-templates#20
Changes in this PR:
unreachable
) to MASM calls. Stubs are identified by fully qualified MASM symbol names.unreachable
stubs exporting those symbols; add build.rs to emit small static archives. Allocator now links tointrinsics::mem::heap_base
; adds its ownunreachable
stub + build.rs archive.Note: I recommend reviewing this PR per commit. Keep in mind that initially I did one big stub library linking in
cargo-miden
and then moved it to the build.rs in the relevant crates with bindings.TODO:
rustc-link-lib=static=[PATH]