Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: l2 to L1 withdrawal #126

Merged
merged 3 commits into from
Oct 24, 2024
Merged

test: l2 to L1 withdrawal #126

merged 3 commits into from
Oct 24, 2024

Conversation

vcastellm
Copy link
Contributor

@vcastellm vcastellm commented Oct 14, 2024

  • L2 to L1 withdrawal test
  • Refactor tests to reduce complexity
  • Bump kurtosis-cdk version to v0.2.15
  • Improve CI by dumping enclave logs + files in kurtosis

Base automatically changed from release/v0.3.0 to main October 17, 2024 16:31
@vcastellm vcastellm changed the base branch from main to develop October 18, 2024 08:44
@vcastellm vcastellm changed the title test: L2 to L1 withdrawal test: l2 to L1 withdrawal Oct 21, 2024
@vcastellm vcastellm requested review from Stefan-Ethernal and a team October 21, 2024 21:03
test/helpers/common.bash Outdated Show resolved Hide resolved
test/helpers/lxly-bridge-test.bash Outdated Show resolved Hide resolved
test/bridge-e2e.bats Outdated Show resolved Hide resolved
test/bridge-e2e.bats Outdated Show resolved Hide resolved
.github/workflows/test-e2e.yml Show resolved Hide resolved
test/combinations/fork11-rollup.yml Show resolved Hide resolved
test/helpers/common.bash Outdated Show resolved Hide resolved
test/helpers/lxly-bridge-test.bash Outdated Show resolved Hide resolved
else
local comp_gas_price=$(bc -l <<< "$gas_price * 1.5" | sed 's/\..*//')
if [[ $? -ne 0 ]]; then
echo "Failed to calculate gas price" >&3
exit 1
fi

echo "cast send --legacy --gas-price $comp_gas_price --rpc-url $l2_rpc_url --private-key $sender_private_key $bridge_addr \"$claim_sig\" \"$in_merkle_proof\" \"$in_rollup_merkle_proof\" $in_global_index $in_main_exit_root $in_rollup_exit_root $in_orig_net $in_orig_addr $in_dest_net $in_dest_addr $in_amount $in_metadata" >&3
cast send --legacy --gas-price $comp_gas_price --rpc-url $l2_rpc_url --private-key $sender_private_key $bridge_addr "$claim_sig" "$in_merkle_proof" "$in_rollup_merkle_proof" $in_global_index $in_main_exit_root $in_rollup_exit_root $in_orig_net $in_orig_addr $in_dest_net $in_dest_addr $in_amount $in_metadata
echo "cast send --legacy --gas-price $comp_gas_price --rpc-url $destination_rpc_url --private-key $sender_private_key $bridge_addr \"$claim_sig\" \"$in_merkle_proof\" \"$in_rollup_merkle_proof\" $in_global_index $in_main_exit_root $in_rollup_exit_root $in_orig_net $in_orig_addr $in_dest_net $in_dest_addr $in_amount $in_metadata" >&3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not needed but I prefer to leave it for convenience, wdyt?

Copy link
Contributor

@ToniRamirezM ToniRamirezM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make Checking PR semantic rule pass.

- L2 to L1 withdrawal test
- Refactor tests to reduce complexity
- Bump kurtosis-cdk version to v0.2.15
- Improve CI by dumping enclave logs + files in kurtosis
test: l2 to L1 withdrawal

* L2 to L1 withdrawal test
* Refactor tests to reduce complexity
* Bump kurtosis-cdk version to v0.2.15
* Improve CI by dumping enclave logs + files in kurtosis
ci: dump the enclave

test: apply feedback
Copy link

sonarcloud bot commented Oct 24, 2024

@vcastellm vcastellm merged commit 3a35c8e into develop Oct 24, 2024
11 checks passed
@vcastellm vcastellm deleted the vcastellm/withdrawal-e2e branch October 24, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants