feat: use sqlite on claimsponsor #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaubennassar
changed the title
goran-ethernal
approved these changes
Nov 5, 2024
claimsponsor/claimsponsor.go
Outdated
| if globalIndexBytes == nil { | ||
| return nil, db.ErrNotFound | ||
| if rowsAff == 0 { | ||
| return fmt.Errorf("the claim requested to be updated does not exist") |
There was a problem hiding this comment.
You can move this error to some global var since you are using it on couple of places in the file.
|
ToniRamirezM
added a commit
that referenced
this pull request
Nov 6, 2024
* feat: calculate acc input hash locally * fix: test * feat: Add `metadata` field on the certificate (#151) * feat: use metadata field on certificate * fix: lint and UT * fix: comments * fix: test * fix: use calculated acc input hash in input prover * fix: use calculated acc input hash in input prover * fix: tests * fix: tests * fix: tests * fix: tests * feat: change timestamp * feat: change timestamp * minor improvements on the config (#149) * fix: revert changes on calculation of merkel proof (#156) * feat: change timestamp * feat: update zkevm-ethtx-manager to v0.2.1 (#153) * fix: tests * fix: tests * fix: tests * fix: tests * feat: refactor * fix: typo * fix: lock * feat: use sqlite on lastgersync (#150) * feat use sqlite on lastgersync * apply requests * rm tree migrations * Update lastgersync/processor.go Co-authored-by: Goran Rojovic <[email protected]> --------- Co-authored-by: Goran Rojovic <[email protected]> * feat: use sqlite on claimsponsor (#157) * feat use sqlite on claimsponsor * wip * pass UTs * fix identation * fix identation * rm cover.out * rm tree migrations * make err a var * chore: bump cdk-erigon to v2.1.2 * Revert "chore: bump cdk-erigon to v2.1.2" This reverts commit a5422d2. --------- Co-authored-by: Goran Rojovic <[email protected]> Co-authored-by: Arnau Bennassar <[email protected]> Co-authored-by: Joan Esteban <[email protected]> Co-authored-by: Victor Castell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.