Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to CDK 0.4.0 #336

Merged
merged 5 commits into from
Oct 28, 2024
Merged

feat: update to CDK 0.4.0 #336

merged 5 commits into from
Oct 28, 2024

Conversation

ToniRamirezM
Copy link
Contributor

Description

Config changes to accomodate version 0.4.0 of CDK

References (if applicable)

Reference PR in CDK: 0xPolygon/cdk#138

@ToniRamirezM ToniRamirezM self-assigned this Oct 28, 2024
vcastellm
vcastellm approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Stefan-Ethernal
Stefan-Ethernal approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the [SequenceSender.StreamClient] from the sequence-sender-config.toml

kurtosis-cdk/templates/trusted-node/sequence-sender-config.toml

Line 16 in bf72585

[SequenceSender.StreamClient]
?

@ToniRamirezM
Copy link
Contributor Author

ToniRamirezM commented Oct 28, 2024 •
edited
Loading

Should we remove the [SequenceSender.StreamClient] from the sequence-sender-config.toml

kurtosis-cdk/templates/trusted-node/sequence-sender-config.toml

Line 16 in bf72585

[SequenceSender.StreamClient]

?

I think this is for the legacy one. So I will keep it as it is.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

leovct
leovct approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leovct leovct enabled auto-merge (squash) October 28, 2024 10:27
@leovct leovct merged commit 90ee2eb into main Oct 28, 2024
22 checks passed
@leovct leovct deleted the feature/removeDSFromAggregator branch October 28, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@leovct leovct leovct approved these changes

@vcastellm vcastellm vcastellm approved these changes

@praetoriansentry praetoriansentry Awaiting requested review from praetoriansentry praetoriansentry is a code owner

Assignees

@ToniRamirezM ToniRamirezM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ToniRamirezM @vcastellm @leovct @Stefan-Ethernal