Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for contract code ending in an empty push pre fork 10 #1159

Open
wants to merge 4 commits into
base: zkevm
Choose a base branch
from

Conversation

hexoscott
Copy link
Collaborator

No description provided.

revitteth
revitteth previously approved these changes Sep 11, 2024
@hexoscott hexoscott marked this pull request as draft September 12, 2024 08:46
@hexoscott hexoscott marked this pull request as ready for review September 24, 2024 15:46
mandrigin
mandrigin previously approved these changes Nov 4, 2024
@afa7789 afa7789 dismissed stale reviews from mandrigin and revitteth via 21a9999 November 6, 2024 20:10
Copy link
Collaborator

@afa7789 afa7789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we be using the push code reference here instead of hardcoded number ?

something like :
"github.com/ledgerwatch/erigon/core/vm" with vm.PUSH1 not sure if this is it tough.

or is it cause it can be any of these ?

image

@hexoscott
Copy link
Collaborator Author

Using the variable over a magic number would be nice 👍 I guess it could be any of these push opcodes but the original issue was specifically for a PUSH1 without anything to actually push to the stack after it, like a trailing push. Probably a good idea to check with Ignasi at Polygon, we might need something more sophisticated to handle the other push opcodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants