-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for contract code ending in an empty push pre fork 10 #1159
base: zkevm
Are you sure you want to change the base?
Conversation
812468b
to
007b0f9
Compare
21a9999
to
8ee1f5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the variable over a magic number would be nice 👍 I guess it could be any of these push opcodes but the original issue was specifically for a PUSH1 without anything to actually push to the stack after it, like a trailing push. Probably a good idea to check with Ignasi at Polygon, we might need something more sophisticated to handle the other push opcodes. |
No description provided.