Rate Limit Revamp #41
Conversation
Yes, I will provide an example soon.
There is no change on the way the server client communication (see ridl file), so client apps should continue to work as before. Upgrading an existing app will require a some changes, but the resulting code should be cleaner, and a few of the issue we encountered should also be taken care of. |
klaidliadon
force-pushed
the
ratelimit-revamp
branch
from
7679d65 to
0dd4494
Compare
klaidliadon
force-pushed
the
ratelimit-revamp
branch
from
84e237a to
bd55a24
Compare
| return cfg, true | ||
| } | ||
|
|
||
| type rcpRequest struct { |
There was a problem hiding this comment.
This is a WebRPC request that is parsed and checked in AccessControl middleware.
| // Session middleware that detects the session type and sets the account or service on the context. | ||
| func Session() func(http.Handler) http.Handler { | ||
| return func(next http.Handler) http.Handler { | ||
| return session{Next: next} |
There was a problem hiding this comment.
I don't follow why instantiating session struct is necessary
why not write the logic directly in this MW?
There was a problem hiding this comment.
I created a struct for each middleware. Just for consistency.
There was a problem hiding this comment.
I noticed -- but I don't think it's necessary :)
You can create local variables in the first function returning the MW function :)
func Session() func(http.Handler) http.Handler {
// create vars here
return func(next http.Handler) http.Handler {
// MW
}
}
Anyway, not a blocker ;)
This PR accomplishes a few things:
SetCredentialsmiddleware allows to pass ajwtauth.JWTAuth, to check for the JWT in the context and use the project claim, to set the project in the context.VerifyQuotauses the project from the context to get the project quota, or the access ket to get the access quota.Sessionmiddleware that it sets the session type in the context, depending on JWT and AccessKeyAccessControlmiddleware that receives a list of service/endpoints + permissions and credits cost, verifies that the session type fromSessionis allowed and sets the compute units forEnsureQuotaandSpendQuotaTODO: