[FEATURE] Ajouter des états succès/erreur au Checkbox tile (PIX-12834)
#669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr669.review.pix.fr |
pix-service-auto-merge
force-pushed
the
docs-checkbox-radio
branch
from
dc7d743
to
e616e59
Compare
yannbertrand
force-pushed
the
pix-12834-add-checkbox-states
branch
from
2d6ef1a
to
352ddaa
Compare
|
Petit soucis au niveau de l'icône quand le 
|
yannbertrand
force-pushed
the
pix-12834-add-checkbox-states
branch
2 times, most recently
from
d6312d2
to
80a1cc1
Compare
|
J'ai l'impression que les icones ne sont pas centré dans leur bulles. ( c'est peut être que moi ) 🤔 |
Ouais je suis pas convaincu des svg là ça fait des trucs bizarres. Peut être qu'il y a une autre approche qui serait meilleure ? |
xav-car
reviewed
Jun 13, 2024
xav-car
approved these changes
Jun 13, 2024
reibecca
force-pushed
the
pix-12834-add-checkbox-states
branch
3 times, most recently
from
8aef4a5
to
c9f3580
Compare
Jeyffrey
approved these changes
Jun 13, 2024
AnaisAllamand
approved these changes
Jun 14, 2024
reibecca
force-pushed
the
pix-12834-add-checkbox-states
branch
2 times, most recently
from
e70be27
to
1d95ff8
Compare
reibecca
force-pushed
the
pix-12834-add-checkbox-states
branch
from
1d95ff8
to
c291a35
Compare
pix-service-auto-merge
pushed a commit
that referenced
this pull request
Jun 14, 2024
# [46.10.0](v46.9.5...v46.10.0) (2024-06-14) ### 🚀 Amélioration - [#669](#669) Ajouter des états succès/erreur au Checkbox `tile` (PIX-12834)
|
🎉 This PR is included in version 46.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Dans la variante
tile, on souhaite avoir un design particulier si une checkbox/radio cochée etisDisabledest en succès ou en erreur.🎁 Proposition
Ajouter un paramètre
statequi prend les valeurs suivantes :neutral(défaut),success,error.Maquettes : https://www.figma.com/design/47MuKB1wXoLEgMal06idN3/R%26D-DevComp?node-id=3835-4921&m=dev
🌟 Remarques
RAS
🎅 Pour tester
Vérifier les nouvelles stories et les différents états mélangés.