Skip to content

Commit

Permalink
tech: remove size parameter when scaling review apps
Browse files Browse the repository at this point in the history
  • Loading branch information
MathieuGilet committed Sep 19, 2024
1 parent 06806e1 commit 9b6d641
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions lib/ReviewAppClient.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class ReviewAppClient {
const apps = await this._getReviewsApps();
const activeReviewApps = apps.filter((app) => app.status === 'new' || app.status === 'running');
return Promise.all(activeReviewApps.map(async (app) => {
await this.scale(app, [{ name: 'web', size: 'S', amount: 0 }])
await this.scale(app, [{ name: 'web', amount: 0 }])
}));
}

Expand All @@ -119,7 +119,7 @@ class ReviewAppClient {

const result = [];
for (const app of activeReviewApps) {
result.push(this.scale(app, [{name: 'web', size: 'S', amount: 1}]));
result.push(this.scale(app, [{name: 'web', amount: 1}]));
await delay(this._reviewAppRestartDelay);
}
return result;
Expand Down
2 changes: 1 addition & 1 deletion test/ReviewAppClient.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe('ReviewAppClient', () => {
describe('#scale()', () => {

const app = { name: 'my-review-app' };
const formation = [{ name: 'web', size: 'S', amount: 0 }];
const formation = [{ name: 'web', amount: 0 }];

it('should call Scalingo API through the Scalingo client `Containers` services', async () => {
// given
Expand Down

0 comments on commit 9b6d641

Please sign in to comment.