Skip to content

Conversation

@dkotter
Copy link
Collaborator

@dkotter dkotter commented Mar 21, 2025

Description of the Change

In order to help protect against compromised actions, instead of including actions based on their major version (like v4), this PR switches all the actions we use to pull based on the commit hash from the latest release.

While this does impact maintenance a bit going forward, it ensures that we we're always using actions that we (hopefully) trust and if an action gets compromised (which happens) we don't have to worry that we're using a compromised action. This also goes along with what GitHub suggests.

Also fixes our E2E workflow which is broken coming out of #148 and #168. We still have one test that fails so I've marked that as skipped for now. An update will be needed to get that working (from what I can tell, the test has never worked).

How to test the Change

Ensure all our workflows still run as expected

Changelog Entry

Developer - Update all third-party actions our workflows rely on to use versions based on specific commit hashes.

Credits

Props @dkotter, @jeffpaul

Checklist:

@dkotter dkotter added this to the 1.2.0 milestone Mar 21, 2025
@dkotter dkotter self-assigned this Mar 21, 2025
@dkotter dkotter removed the request for review from davidrgreen March 21, 2025 20:41
@dkotter dkotter force-pushed the update/pin-workflow-actions branch from 3effd2e to d596aae Compare March 21, 2025 21:02
@dkotter dkotter mentioned this pull request Mar 21, 2025
4 tasks
@jeffpaul
Copy link
Member

@vikrampm1 please open an issue for us to tackle the following:

Also fixes our E2E workflow which is broken coming out of #148 and #168. We still have one test that fails so I've marked that as skipped for now. An update will be needed to get that working (from what I can tell, the test has never worked).

@dkotter dkotter merged commit a2a7e34 into develop Mar 25, 2025
11 checks passed
@dkotter dkotter deleted the update/pin-workflow-actions branch March 25, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants