-
Notifications
You must be signed in to change notification settings - Fork 59
[Enhancement] Support WooCommerce Product-Based Title & Excerpt Generation #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good. Made a few minor changes and fixed a bug but there's still one major thing that needs fixed.
Generating titles and inserting those work and generating an excerpt works but inserting it does not. I think our JS that handles this needs updated to account for the TinyMCE editor Woo uses, whereas the normal excerpt input is just a textarea. Would also be nice to update the button text to make it clear it's generating a short product description and not an excerpt.
Also, if we could get some E2E tests here that would be great. Don't know if we need tests for each individual Provider but at least need one test to ensure titles can be generated and inserted on a product and that excerpts can be generated and inserted on a product (will need to install Woo to test that)
@dkotter The newly added tests are passing, but a few of the old ones have started failing. I’m skipping resolving them here for now as they seem unrelated. |
Tests are currently passing on |
Description of the Change
This PR enhances the title and excerpt generation feature to support WooCommerce products. It fetches key product details such as name, type, SKU, categories, attributes, price, stock status, and descriptions to generate optimized and high-converting titles and excerpts tailored for e-commerce. The implementation ensures compatibility with existing functionality while adding WooCommerce-specific logic for improved accuracy and relevance.
Closes #98 (Yet to determine if Woo Content & Tagging Generations will be included in this PR or handled separately).
How to test the Change
Changelog Entry
Credits
Props @jeffpaul @dkotter @faisal-alvi
Checklist: