Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Synced Patterns, Overrides, and Block Bindings API pages #171

Merged
merged 11 commits into from
Oct 1, 2024

Conversation

colinswinney
Copy link
Contributor

Description of the Change

This PR reorganizes the reference pages to include a separate section for Patterns. Additionally it creates reference material for Synced Patterns, Synced Pattern Overrides, and the Block Bindings API.

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
10up-gutenberg-best-practices ✅ Ready (Inspect) Visit Preview 6 resolved Oct 1, 2024 6:39am

@fabiankaegy
Copy link
Member

Hey @colinswinney 👋

Thank you for this ❤️ I'll review it in depth soon!

In the mean time there seems to be a build failure. You should be able to test it locally by running the build instead of watch command :)

@colinswinney
Copy link
Contributor Author

Thanks @fabiankaegy, got the build sorted out now. Let me know your thoughts, there's definitely some opinionated sections so I would love to know if you feel it meets best practices.

https://10up-gutenberg-best-practices-qdxmkrvai-fabiankaegys-projects.vercel.app/reference/Patterns/synced-patterns

@fabiankaegy
Copy link
Member

@colinswinney I added some comments right in the vercel preview :)

(I thought they would sync back here but they don't :( Let me know if you have any issues seeing them)

reference/04-Patterns/overview.md Show resolved Hide resolved
reference/04-Patterns/synced-patterns.md Outdated Show resolved Hide resolved
reference/04-Patterns/synced-patterns.md Outdated Show resolved Hide resolved

![Call to action with default settings applied](../../static/img/block-pattern-call-to-action-example.jpg)
<br/>
*Call to action with default settings applied*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core post meta bindings are now also editable inline in the editor which may be nice to add :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with that, can you expand upon this or perhaps share a screenshot?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In WordPress 6.6 it is now possible to actually edit the value that is saved in post meta right inline as you are editing the text of a bound block. So it no longer just displays the text but now also allows you to update it.

Copy link
Contributor Author

@colinswinney colinswinney Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably missing something, but I don't see how this is possible within a Block Bound pattern? The only option available for editing is to "Edit Original", none of the innerblocks are selectable.

Screenshot 2024-10-01 at 8 47 22 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might only be possible to edit bound fields that are not inside of synced patterns.

We can leave it out for now :)

reference/04-Patterns/block-bindings-api.md Outdated Show resolved Hide resolved
@fabiankaegy fabiankaegy merged commit afa6178 into main Oct 1, 2024
6 checks passed
@fabiankaegy fabiankaegy deleted the feature/reorganize-patterns branch October 1, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants