Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude the 10up-lib directory from the PHPCS check. #207

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Sep 3, 2024

Description of the Change

PR excludes the 10up-lib directory from the PHPCS check to fix the PHPCS GitHub action workflow. 10up-lib directory contains the https://github.com/10up/wp-compat-validation-tool composer package.

How to test the Change

  • Verify that the Linting / eslint GitHub action check is passing.

Changelog Entry

Fixed - Ensure that the PHPCS check in the GitHub Action works properly

Credits

Props @iamdharmesh

Checklist:

@github-actions github-actions bot added this to the 1.3.6 milestone Sep 3, 2024
@iamdharmesh iamdharmesh marked this pull request as ready for review September 3, 2024 06:34
@iamdharmesh iamdharmesh requested review from faisal-alvi and removed request for dkotter and jeffpaul September 3, 2024 06:34
@github-actions github-actions bot added the needs:code-review This requires code review. label Sep 3, 2024
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@faisal-alvi faisal-alvi merged commit 5ef2675 into develop Sep 3, 2024
13 checks passed
@faisal-alvi faisal-alvi deleted the fix/phpcs branch September 3, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants