Skip to content

Conversation

mindctrl
Copy link

Description of the Change

Changes the PHPDoc on PostToPost::to from string to array, so that it accurately reflects the data stored there, which fixes warnings where an IDE thinks things like count() are being run against a string when they're not.

Benefits

Better developer experience.

Possible Drawbacks

None that I'm aware of.

Verification Process

  • I changed the PHPDoc from string to array and verified that my IDE no longer complains about count() being used with an improper data type.

No functional changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed PHPDoc for PostToPost::to property.

@jeffpaul jeffpaul added this to the 1.6.0 milestone Aug 18, 2021
@jeffpaul jeffpaul requested a review from moraleida August 18, 2021 15:28
@mindctrl mindctrl removed their assignment Jul 18, 2023
@mindctrl mindctrl closed this by deleting the head repository Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants