Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional filters for the Post UI queries #67

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

s3rgiosan
Copy link
Member

@s3rgiosan s3rgiosan commented Sep 7, 2022

Description of the Change

We have a use case where the 10 posts UI limit is not enough.
While pagination support is the preferred approach (see #50), this PR addresses the problem with a low-impact approach as long as the number of relationships isn't too high. In our case, it is less than 25.

How to test the Change

Changelog Entry

Added - Filters for the Post UI WP_Query and WP_User_Query args.

Credits

Props @s3rgiosan

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@s3rgiosan
Copy link
Member Author

@jeffpaul for visibility

@jeffpaul jeffpaul added this to the 1.6.0 milestone Sep 22, 2022
@s3rgiosan
Copy link
Member Author

Hi @rickalee, can I have your 👀 on this one?

cc @jeffpaul

@jeffpaul
Copy link
Member

I'm indifferent on this one, so if RLW is 👍🏼 then we can merge and push a minor release for you (though there's a bunch of Dependabot updates that would be ideal to review/merge).

@rickalee
Copy link

Looks good to me. Let's merge. @jeffpaul

@jeffpaul jeffpaul merged commit 4a39cbb into 10up:master Sep 19, 2023
@s3rgiosan s3rgiosan deleted the feature/post-ui-query-filter branch November 2, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants