Skip to content

Recognize .ico files with a search query #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
binyamin wants to merge 1 commit into from
Closed

Recognize .ico files with a search query #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion functions/avatar/avatarHtml.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,10 @@ class AvatarHtml {

let relIcons = this.findRelIcons();
if(relIcons.length) {
if(relIcons[0].type === "x-icon" || relIcons[0].href && relIcons[0].href.endsWith(".ico")) {
const isIco = relIcons[0].type === 'x-icon'
|| relIcons[0].href.split(/[#?]/)[0].endsWith('.ico');

if(isIco) {
let pngBuffer = await this.convertIcoToPng(relIcons[0].href, width);
return this.optimizeAvatar(pngBuffer, width, "png");
} else {
Expand Down
4 changes: 3 additions & 1 deletion test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ const AvatarHtml = require("./functions/avatar/avatarHtml");
// let url = "https://www.youtube.com/watch?v=eRRkvI-w5Ik";
// let url = "https://lynnandtonic.com";
// let url = "https://sarah.dev/";
let url = "https://changelog.com/jsparty/217";
// let url = "https://changelog.com/jsparty/217";
let url = "https://everyday.app/" // [favicon] ico with search params

console.log( url );
let avatar = new AvatarHtml(url);
let html = await avatar.fetch();
Expand Down