Manually correct social media external links #4057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution options here were:
(1) spend a long time figuring out why the Markdown renderer that's supposed to handle links isn't seeing the "18F on {platform}" links in the social media sidebar, or
(2) manually mark them external.
I opted for (2) just to get the migration done for now. I've opened another issue to handle this more systematically — our renderers are in rough shape.
beechnut
force-pushed
the
replatform/prerelease
branch
from
b47beae to
f4c08fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution options here were:
I opted for 2 just to get the migration done for now.
I've listed a task in #3864 to handle this more systematically — our renderers not in good condition to be maintainable in the long run, so this is pennies on top of an already hefty technical debt.
Fixes #4053