Skip to content

perf: application overview update Text#1965

Merged
wangdan-fit2cloud merged 1 commit intomainfrom
pr@main@perf-bugs
Jan 2, 2025
Merged

perf: application overview update Text#1965
wangdan-fit2cloud merged 1 commit intomainfrom
pr@main@perf-bugs

Conversation

@shaohuzhang1
Copy link
Contributor

perf: application overview update Text

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 2, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

import { isAppIcon, isWorkFlow } from '@/utils/application'
import applicationXpackApi from '@/api/application-xpack'
import { MsgSuccess, MsgError } from '@/utils/message'
import { t } from '@/locales'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet has a few minor adjustments:

  1. Typographical Error: In the first el-checkbox, add quotes around the label to fix '显示知识来源'.
  2. Import Statement: Ensure the import statement for applicationXpackApi is correct.
  3. Variable Usage: Use isWorkFlow(detail.type) correctly in setting the checkbox label.

Here's the corrected version of the code:

@@ -264,7 +264,10 @@
           </el-card>
 
           <el-space direction="vertical" alignment="start" :size="2">
-            <el-checkbox v-model="form.show_source" label="'显示知识来源'" />
+            <el-checkbox v-model="form.show_source"
+                         :label="isWorkFlow(detail.type) ? '显示执行详情' : '显示知识来源'"
+                       />
             <el-checkbox v-model="form.show_history" label="显示历史记录" />
             <el-checkbox v-model="form.show_guide" label="显示引导图(浮窗模式)" />
             <el-checkbox v-model="form.disclaimer" label="免责声明" @change="changeDisclaimer" />
@@ -298,7 +301,7 @@
 import { computed, ref, watch } from 'vue'
 import { useRoute } from 'vue-router'
 import type { FormInstance, FormRules, UploadFiles } from 'element-plus'
-import { isAppIcon } from '@/utils/application'
+import { isAppIcon, isWorkFlow } from '@/utils/application'
 import applicationXpackApi from '@/api/application-xpack'
 import { MsgSuccess, MsgError } from '@/utils/message'
 import { t } from '@/locales'

These changes address the typographical error and ensure that isWorkFlow(detail.type) is used correctly in setting the checkbox label.

@wangdan-fit2cloud wangdan-fit2cloud merged commit 4db8c9c into main Jan 2, 2025
4 checks passed
@wangdan-fit2cloud wangdan-fit2cloud deleted the pr@main@perf-bugs branch January 2, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants