fix: Knowledge workflow route

[shaohuzhang1]

fix: Knowledge workflow route

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The JavaScript code you provided is a part of a React Router router configuration for managing different sections within an application. There are several potential improvements and clarifications needed:

1. Duplicate activeMenu Path: The parentPath (newly added) includes /knowledge:id:folderId:type, while activeMenu has only /knowledge. This redundancy might not be intentional, especially if they represent the same functionality.

2. Variable Naming Convention: It's generally good practice to use consistent naming conventions across your project. Ensure that variable names like to follow standard JavaScript conventions.

3. Function Scope Considerations: If get_next_route() is meant to return something based on some logic, consider defining it with proper scope or importing where necessary.

4. Code Readability: Adding comments can help clarify what each part of the routing configuration does.

Here’s the revised version of your code:

const DocumentRouter = {
  path: '/document', // Base route for documents
  routes: [
    {
      pattern: '/workflow/:id',
      component: WorkflowComponent,
      exact: true,
      meta: { 
        menuTitle: 'Workflow Details', 
        icon: 'application-list-icon' 
      },
      children: [
        {
          path: ':folderId',
          exact: true,
          component: FolderDetailsComponent,
          metaData: { menuTitle: 'Folder Details', activeMenu: '/documents/workflow/:id/:folderId', permission: [] }
        },
        {
          path: ':folderId/view/:type',
          exact: true,
          component: ViewDocumentComponent,
          metaData: {
            menuTitle: 'View Document',
            activeMenu: '/documents/workflow/:id/:folderId/:type',
            parentName: 'FolderDetails',
            resourceType: SourceTypeEnum.DOCUMENT,
            group: 'DocumentDetail'
          }
        }
      ]
    }
  ],
};

Key Changes:

• Added a base route /document instead of duplicating workflow.
• Introduced metaData object to store metadata properties more logically grouped.
• Cleaned up syntax for clarity.
• Assumed WorkflowComponent, FolderDetailsComponent, and other components have been imported or defined elsewhere in your project.

Make sure to update accordingly based on your actual implementation details.