fix: Workflow save before publish

[shaohuzhang1]

fix: Node height
fix: Workflow save before publish

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The provided code snippet needs some adjustments to correct the method name used for setting knowledge workflows. The putKnowledge method uses a different endpoint than expected. Additionally, it's good practice to handle errors properly and ensure consistency in logic flow.

Here is an optimized version of the function with these improvements:

const publish = async () => {
  if (!id || !workflow) {
    return;
  }

  try {
    await loadSharedApi({
      type: 'knowledge',
      systemType: apiType.value,
    }).putKnowledgeWorkflow(id, { work_flow: workflow });

    // Assuming there should be a similar method for publishing, you might have:
    await loadSharedApi({
      type: 'knowledge',
      systemType: apiType.value,
    }).publish(id);
    
  } catch (error) {
    console.error('Error publishing knowledge:', error);
  }
};

Key Changes and Suggestions:

1. Correct Method Name: Changed putKnowledge to putKnowledgeWorkflow. This assumes that you intended to call a specific method related to configuring or updating workflow settings for a piece of knowledge.
2. Asynchronous Await: Used async/await to make the fetching operations more readable and easier to understand.
3. Error Handling: Added a try-catch block to catch any synchronous exceptions during API calls and log them.
4. Consistent Logic Flow: Ensured that both the configuration of the workflow and the publication process occur sequentially within one transaction for better reliability and data integrity.