Add 204 as a valid status code for DELETE operation in api.py #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This addresses issue #70 |
volodymyrZotov
approved these changes
Sep 7, 2023
Contributor
volodymyrZotov
left a comment
volodymyrZotov
left a comment
There was a problem hiding this comment.
Good and straightforward fix! 👍
Contributor
|
@alexbartok It requires the commit to be signed In order for this to be merged. Could you please do that? |
As per the 1Password Connect Server API reference, the expected status code for DELETE operation is 204. api.py would always expect a 200 status code, so a successful DELETE operation incorrectly register as a failure. This commit adds 204 as a success status code. Ref: https://developer.1password.com/docs/connect/connect-api-reference/#delete-an-item Co-authored-by: Eddy Filip <[email protected]>
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the 1Password Connect Server API reference, the expected status code for DELETE operation is 204. api.py would always expect a 200 status code, so a successful DELETE operation incorrectly registered as a failure. This commit adds 204 as a success status code. Ref: https://developer.1password.com/docs/connect/connect-api-reference/#delete-an-item