Update README to simplify service account instructions #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Marton6 What do you think of this approach to updating and simplifying the service account creation instructions? If you prefer the original, I'm happy to switch back and only update the link. After you review, I'll open PRs to update the other READMEs as well. |
Marton6
approved these changes
Jul 18, 2024
I like these new instructions, they are a bit easier to read IMO. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR updates the README to directly link to the 1password.com page where you can create a service account. It also simplifies the service account information by moving this instruction into the get started section and removing the authentication section.
Relates to this issue: https://gitlab.1password.io/dev/sdk/sdk-core/-/issues/141#note_3220318