-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: global refactoring #38
Conversation
EnoRage
commented
Mar 21, 2024
•
edited
Loading
edited
- namings and 3rd party APIs removed (tenderly, swagger -> openapi, cli logic removed)
- abstract http executor interface with default impl at separate pkg (using common pkg to declare interface to split impl from usage)
- web3 provider interface that allows to execute web3 operations and can be switched to other option
- add Aggregation SDK as sep. package with new config and client structs
- add Balances SDK as sep. package
- add Spot Prices SDK as sep. package
- add Gas Prices SDK as sep. package
- add Broadcast Transaction SDK as sep. package
- add NFT SDK as sep. package
- add History SDK as sep. package
- add Traces SDK as sep. package
- add Tokens SDK as sep. package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the Tenderly simulations removed, we will need to be more precise with our unit testing. The first thing that comes to mind after our last conversation is to do local testing for permits (and fallback to approvals when the token does not support permits or something with the permit generation fails).
I also want to note that doing real requests to the downstream APIs has provided value. Here is an example of a bug caught by sending requests to Limit Order API: https://1inch.atlassian.net/browse/DPA-914
Co-authored-by: Roman Averianov <[email protected]> Co-authored-by: Tanz0rz <[email protected]>
Co-authored-by: Tanz0rz <[email protected]>
Co-authored-by: Tanz0rz <[email protected]>
Co-authored-by: Nick Kozlov <[email protected]>
…erall structure (#58) Co-authored-by: Nick Kozlov <[email protected]>
…ched Orderbook client/configuration structure to Aggregation (#66)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge this as it is now. There is still some important cleanup to, but this PR is getting too big and the current refactor is fully functional.
Some notes for follow-up PRs:
- Improve codegen logic to make all query params concrete types even when they are optional
- Cleanup example program outputs
- Add additional APIs like Portfolio